Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(NumberTheory/EllipticDivisibilitySequence): expose the auxiliary sequence #10814

Closed
wants to merge 3 commits into from

Conversation

Multramate
Copy link
Collaborator

Expose the auxiliary sequences associated to normalised elliptic divisibility sequences along with their corresponding API, and fix the comments under implementation notes. This is needed to define $n$-division polynomials of elliptic curves in a later downstream file as univariate polynomials with the factor of the bivariate $2$-division polynomial omitted.


Open in Gitpod

normEDS'' b c d (m + 4) * normEDS'' b c d (m + 2) ^ 3 * (if Even m then b ^ 4 else 1) -
normEDS'' b c d (m + 1) * normEDS'' b c d (m + 3) ^ 3 * (if Even m then 1 else b ^ 4)
preNormEDS' b c d (m + 4) * preNormEDS' b c d (m + 2) ^ 3 * (if Even m then b else 1) -
preNormEDS' b c d (m + 1) * preNormEDS' b c d (m + 3) ^ 3 * (if Even m then 1 else b)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
preNormEDS' b c d (m + 1) * preNormEDS' b c d (m + 3) ^ 3 * (if Even m then 1 else b)
preNormEDS' b c d (m + 1) * preNormEDS' b c d (m + 3) ^ 3 * (if Even m then 1 else b)

From the Style Guide: "This rule, i.e., indent an additional two spaces, applies more generally whenever a term spans multiple lines."

@MichaelStollBayreuth MichaelStollBayreuth added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Mar 3, 2024
@riccardobrasca riccardobrasca self-assigned this Mar 4, 2024
@alreadydone
Copy link
Contributor

alreadydone commented May 15, 2024

@Multramate Can you merge master and fix the indentation as pointed out by @MichaelStollBayreuth? I'd like to use preNormEDS to define $\psi^c_n=\psi_{2n}/\psi_n=(\psi_{n-1}^2\psi_{n+2}-\psi_{n-2}\psi_{n+1}^2)/\psi_2$ in my notes in a division-free way. I think the correct definition is normEDSCompl n := (preNormEDS (n-1) * preNormEDS (n+2) ^ 2 - preNormEDS (n-2) * preNormEDS (n+1) ^ 2) * (if Even n then 1 else b) where preNormEDS is applied to the parameters b^4, c, d, and I'll then show normEDS n * normEDSCompl n = normEDS (2 * n).

Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@alreadydone alreadydone removed the awaiting-author A reviewer has asked the author a question or requested changes label May 16, 2024
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label May 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 16, 2024
… sequence (#10814)

Expose the auxiliary sequences associated to normalised elliptic divisibility sequences along with their corresponding API, and fix the comments under implementation notes. This is needed to define $n$-division polynomials of elliptic curves in a later downstream file as univariate polynomials with the factor of the bivariate $2$-division polynomial omitted.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/EllipticDivisibilitySequence): expose the auxiliary sequence [Merged by Bors] - feat(NumberTheory/EllipticDivisibilitySequence): expose the auxiliary sequence May 16, 2024
@mathlib-bors mathlib-bors bot closed this May 16, 2024
@mathlib-bors mathlib-bors bot deleted the EllipticDivisibilitySequence branch May 16, 2024 08:10
callesonne pushed a commit that referenced this pull request May 16, 2024
… sequence (#10814)

Expose the auxiliary sequences associated to normalised elliptic divisibility sequences along with their corresponding API, and fix the comments under implementation notes. This is needed to define $n$-division polynomials of elliptic curves in a later downstream file as univariate polynomials with the factor of the bivariate $2$-division polynomial omitted.
grunweg pushed a commit that referenced this pull request May 17, 2024
… sequence (#10814)

Expose the auxiliary sequences associated to normalised elliptic divisibility sequences along with their corresponding API, and fix the comments under implementation notes. This is needed to define $n$-division polynomials of elliptic curves in a later downstream file as univariate polynomials with the factor of the bivariate $2$-division polynomial omitted.
alreadydone added a commit that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants