-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: continuity of primitives for parametric integrals #11185
Conversation
From sphere-eversion. TODO: should I place all parametric lemmas in a separate section, or leave their order as-is?
a00d960
to
fc56aee
Compare
@lecopivo I'm trying out fun_prop on this lemma - I have two questions for you as the fun_prop expert:
|
Integral is higher order function i.e. having a function as an argument.
In the short term, making that proof working is not within the reach of The best I can offer is this proof
The way
which is not useful. |
At least I will try to think of a linter that would warn you when you tag theorem like The issue is that for some higher order functions stating theorems in 'uncurried form' is fine. For example,
Therefore the linter can't simple check if you are working with higher order function or not. |
This file uses a mix of f and F... to be cleaned up another time.
I will get to this PR eventually, but have other higher-priority things to do right now. If you're reading this, help jumping in and fixing the above is welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some detailed comments on the first file (Stieltjes
). I've also suggested adding some explanatory comments to the big proof in DominatedConvergence
yet – I haven't yet read the proof, but I'd prefer to read it with explanations than without!
A couple of afterthoughts:
|
Thanks a lot, @sgouezel, for rebasing this! This was on my list, to be done after my PhD thesis (i.e. quite soon). |
@semorrison. Kim, you requested my review on this one, must I have written most code in the current version. I would be happy to merge it, but it would probably be more reasonable if someone else reviewed it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another review
bors d+
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks for the review! Since mathlib builds, let's bors this. |
👎 Rejected by label |
The CI error was in curl - not related to this code. |
From the sphere eversion project and generalised by `sgouezel`. This is used in the sphere eversion project to show that averaging of loops is continuous (which will be PRed to mathlib at a later point). Co-authored by: @fpvandoorn (who write this code originally, I believe) Co-authored-by: Ruben Van de Velde <[email protected]> Co-authored-by: sgouezel <[email protected]>
Pull request successfully merged into master. Build succeeded: |
From the sphere eversion project and generalised by
sgouezel
.This is used in the sphere eversion project to show that averaging of loops is continuous (which will be PRed to mathlib at a later point).
Co-authored by: @fpvandoorn (who write this code originally, I believe)