[Merged by Bors] - chore: unify date formatting in lemma deprecations #12334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it, also format some declarations on single lines.
…e same line as the deprecation, if easily possible.
grunweg
added
awaiting-review
tech debt
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
- consistently use the YYYY-MM-DD format - when easily possible, put the date on the same line as the `deprecated` attribute - when easily possible, format the entire declaration on the same line Why these changes? - consistency makes it easier for tools to parse this information - compactness: I don't see a good reason for these declarations taking up more space than needed; as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway - putting the date on the same line as the attribute makes it easier to discover un-dated deprecations; they also ease writing a tool to replace these by a machine-readable version using leanprover/lean4#3968
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
|
Thanks for the fast review! |
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
- consistently use the YYYY-MM-DD format - when easily possible, put the date on the same line as the `deprecated` attribute - when easily possible, format the entire declaration on the same line Why these changes? - consistency makes it easier for tools to parse this information - compactness: I don't see a good reason for these declarations taking up more space than needed; as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway - putting the date on the same line as the attribute makes it easier to discover un-dated deprecations; they also ease writing a tool to replace these by a machine-readable version using leanprover/lean4#3968
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
- consistently use the YYYY-MM-DD format - when easily possible, put the date on the same line as the `deprecated` attribute - when easily possible, format the entire declaration on the same line Why these changes? - consistency makes it easier for tools to parse this information - compactness: I don't see a good reason for these declarations taking up more space than needed; as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway - putting the date on the same line as the attribute makes it easier to discover un-dated deprecations; they also ease writing a tool to replace these by a machine-readable version using leanprover/lean4#3968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecatedattributeWhy these changes?
as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway
they also ease writing a tool to replace these by a machine-readable version using feat: improve @[deprecated] attr leanprover/lean4#3968
All commits can be reviewed individually.
#12335 has a similar change (just formatting things on one line), which I pulled out since that is fairly large.