Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/UniformSpace/AbstractCompletion):add comparison lemma #12979

Closed
wants to merge 13 commits into from

Conversation

faenuccio
Copy link
Collaborator

Add a lemma showing that composing the comparison maps with a continuous function to a T3 space satisfying some conditions yield the same function.

Co-authored with : María Inés de Frutos Fernández @mariainesdff

@faenuccio faenuccio added WIP Work in progress t-topology Topological spaces, uniform spaces, metric spaces, filters labels May 17, 2024
faenuccio and others added 4 commits May 17, 2024 12:35
@faenuccio faenuccio added awaiting-review and removed WIP Work in progress labels May 20, 2024
@faenuccio faenuccio requested a review from PatrickMassot May 20, 2024 09:03
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 16, 2024
Copy link

github-actions bot commented Jun 16, 2024

PR summary bcf0b5b6d9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ compare_comp_eq_compare

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@faenuccio
Copy link
Collaborator Author

I have addressed @urkud 's comments, but I had a private DM with @PatrickMassot who thinks the result is too specialized. IMHO it is OK and it is at the same time useful to have this comparison result, stated under quite general assumptions, but not too general as to be practically unapplicable (I will indeed need it in a later PR proving an equivalence between Laurent series and the X-adic completion of rational functions). I wonder how to advance now.

@faenuccio faenuccio added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 17, 2024
@PatrickMassot PatrickMassot self-assigned this Jul 13, 2024
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 14, 2024

✌️ faenuccio can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@faenuccio
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 15, 2024
…12979)

Add a lemma showing that composing the comparison maps with a continuous function to a T3 space satisfying some conditions yield the same function.

Co-authored  with : María Inés de Frutos Fernández @mariainesdff
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/UniformSpace/AbstractCompletion):add comparison lemma [Merged by Bors] - feat(Topology/UniformSpace/AbstractCompletion):add comparison lemma Jul 15, 2024
@mathlib-bors mathlib-bors bot closed this Jul 15, 2024
@mathlib-bors mathlib-bors bot deleted the fae_PR_extendCompl branch July 15, 2024 19:53
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants