-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Topology/UniformSpace/AbstractCompletion):add comparison lemma #12979
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…mmunity/mathlib4 into fae_PR_extendCompl
PR summary bcf0b5b6d9Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
I have addressed @urkud 's comments, but I had a private DM with @PatrickMassot who thinks the result is too specialized. IMHO it is OK and it is at the same time useful to have this comparison result, stated under quite general assumptions, but not too general as to be practically unapplicable (I will indeed need it in a later PR proving an equivalence between Laurent series and the X-adic completion of rational functions). I wonder how to advance now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ faenuccio can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Patrick Massot <[email protected]>
bors r+ |
…12979) Add a lemma showing that composing the comparison maps with a continuous function to a T3 space satisfying some conditions yield the same function. Co-authored with : María Inés de Frutos Fernández @mariainesdff
Pull request successfully merged into master. Build succeeded: |
Add a lemma showing that composing the comparison maps with a continuous function to a T3 space satisfying some conditions yield the same function.
Co-authored with : María Inés de Frutos Fernández @mariainesdff