Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/Kaehler): The exact sequence I/I² → B ⊗[A] Ω[A⁄R] → Ω[B⁄R] → 0 #13093

Closed
wants to merge 5 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented May 21, 2024


Open in Gitpod

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@erdOne erdOne added awaiting-review t-algebra Algebra (groups, rings, fields, etc) labels May 21, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

PR summary 8ee44bc6f2

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Kaehler.Basic 1150 1151 +1 (+0.09%)

Declarations diff

+ KaehlerDifferential.exact_kerCotangentToTensor_mapBaseChange
+ KaehlerDifferential.kerCotangentToTensor
+ KaehlerDifferential.kerCotangentToTensor_toCotangent
+ KaehlerDifferential.kerToTensor
+ KaehlerDifferential.ker_map_of_surjective
+ KaehlerDifferential.mapBaseChange_surjective
+ KaehlerDifferential.range_kerCotangentToTensor
+ KaehlerDifferential.subsingleton_of_surjective

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 21, 2024
@riccardobrasca riccardobrasca self-assigned this Jun 24, 2024

/-- The map `I/I² → B ⊗[A] B ⊗[A] Ω[A⁄R]` where `I = ker(A → B)`. -/
noncomputable
def KaehlerDifferential.kerCotangentToTensor :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid tactic mode here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hole is a Prop, so I think it's fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean something like

noncomputable
def KaehlerDifferential.kerCotangentToTensor :
    (RingHom.ker (algebraMap A B)).Cotangent →ₗ[A] B ⊗[A] Ω[A⁄R] :=
  Submodule.liftQ _ (kerToTensor R A B) (iSup_le_iff.mpr (by
    simp only [Submodule.map_le_iff_le_comap, Subtype.forall]
    rintro x hx y -
    simp only [Submodule.mem_comap, LinearMap.lsmul_apply, LinearMap.mem_ker, map_smul,
      kerToTensor_apply, TensorProduct.smul_tmul', ← algebraMap_eq_smul_one,
      (RingHom.mem_ker _).mp hx, TensorProduct.zero_tmul]))

Or to prove the thing in a separate lemma (tbh I didn't look at what it is, so I am not sure this is reasonable).

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 24, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@erdOne
Copy link
Member Author

erdOne commented Jun 24, 2024

Thanks!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Kaehler): The exact sequence I/I² → B ⊗[A] Ω[A⁄R] → Ω[B⁄R] → 0 [Merged by Bors] - feat(RingTheory/Kaehler): The exact sequence I/I² → B ⊗[A] Ω[A⁄R] → Ω[B⁄R] → 0 Jun 24, 2024
@mathlib-bors mathlib-bors bot closed this Jun 24, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/kaehlerexact2 branch June 24, 2024 22:12
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants