[Merged by Bors] - feat(GroupTheory/Perm/Cycle/Factors): Remove finiteness requirement from cycleOf. #13145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand this PR is being discussed on zulip - but let me still mark it as awaiting-review, for good measure. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
PR summary f03a538842Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
This seems to be a strict generalisation. Thanks! The linter seems unhappy though. Two lines are more than > 100 chars. After fixing that, please feel free to merge this. bors d+ |
|
✌️ linesthatinterlace can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…rom cycleOf. (#13145) cycleOf can be defined using only a decidability condition, rather than the current finiteness condition (from which decidability can be inferred). This commit removes this dependency on finiteness. Co-authored-by: Wrenna Robson <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
…rom cycleOf. (#13145) cycleOf can be defined using only a decidability condition, rather than the current finiteness condition (from which decidability can be inferred). This commit removes this dependency on finiteness. Co-authored-by: Wrenna Robson <[email protected]>
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
…rom cycleOf. (#13145) cycleOf can be defined using only a decidability condition, rather than the current finiteness condition (from which decidability can be inferred). This commit removes this dependency on finiteness. Co-authored-by: Wrenna Robson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cycleOf can be defined using only a decidability condition, rather than the current finiteness condition (from which decidability can be inferred). This commit removes this dependency on finiteness.