Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Move order theory and algebra out of Data.Fin.Tuple.Basic #13148

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: Move order theory and algebra out of Data.Fin.Tuple.Basic #13148

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented May 23, 2024 •
edited
Loading

  • Move the order theory in Data.Fin.Tuple.Basic to Order.Fin.Basic and a new file Order.Fin.Tuple
  • Move the content of Data.Fin.Tuple.Monotone to Order.Fin.Tuple
  • Move the algebra in Data.Fin.Tuple.Basic and Data.Fin.VecNotation to a new file Algebra.Group.Fin.Tuple

Open in Gitpod

github-actions[bot]
github-actions bot reviewed May 23, 2024
View reviewed changes
@YaelDillies YaelDillies changed the base branch from delete_fin_order_hom to master May 23, 2024 18:21
@YaelDillies YaelDillies added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) awaiting-review awaiting-CI t-algebra Algebra (groups, rings, fields, etc) t-order Order theory labels May 23, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch 2 times, most recently from c208926 to e1b0490 Compare May 24, 2024 08:26
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 24, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from e1b0490 to 139b176 Compare May 24, 2024 18:21
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels May 24, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 139b176 to 224573d Compare May 27, 2024 09:04
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) blocked-by-other-PR and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels May 27, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label May 30, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 224573d to f451443 Compare May 30, 2024 13:30
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels May 30, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from f451443 to 28a726d Compare May 30, 2024 19:14
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels May 30, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 28a726d to 41e1dde Compare May 31, 2024 20:56
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 54843da to 4264fac Compare June 28, 2024 07:59
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jun 28, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 8ea6633 to 12364fc Compare July 1, 2024 11:30
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 1, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 12364fc to 024ec50 Compare July 9, 2024 16:57
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 9, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from 024ec50 to d71e8fe Compare July 12, 2024 06:52
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 12, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 15, 2024

There are some pretty significant import increases to some files. Can these please be avoided?

@kim-em kim-em added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 16, 2024
@YaelDillies YaelDillies force-pushed the lighten_fin_tuple_basic branch from d71e8fe to 882a44f Compare July 16, 2024 16:44
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 16, 2024
@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 16, 2024
@YaelDillies
Copy link
Collaborator Author

There are some pretty significant import increases to some files. Can these please be avoided?

Good now

@kim-em
Copy link
Contributor

kim-em commented Jul 17, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 17, 2024
@YaelDillies
chore: Move order theory and algebra out of Data.Fin.Tuple.Basic (#…
7d65c07 
…13148)

* Move the order theory in `Data.Fin.Tuple.Basic` to `Order.Fin.Basic` and a new file `Order.Fin.Tuple`
* Move the content of `Data.Fin.Tuple.Monotone` to `Order.Fin.Tuple`
* Move the algebra in `Data.Fin.Tuple.Basic` and `Data.Fin.VecNotation` to a new file `Algebra.Group.Fin.Tuple`
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Move order theory and algebra out of Data.Fin.Tuple.Basic [Merged by Bors] - chore: Move order theory and algebra out of Data.Fin.Tuple.Basic Jul 17, 2024
@mathlib-bors mathlib-bors bot closed this Jul 17, 2024
@mathlib-bors mathlib-bors bot deleted the lighten_fin_tuple_basic branch July 17, 2024 18:38
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YaelDillies @leanprover-community-mathlib4-bot @kim-em @Ruben-VandeVelde