[Merged by Bors] - refactor(Algebra/Star/StarAlgHom): mk_coe and coe_mk in StarAlgHom
#13267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
reviewed
Jun 3, 2024
Mathlib/Algebra/Star/StarAlgHom.lean
Outdated
Comment on lines
904
to
905
| theorem mk_coe' (e : A ≃⋆ₐ[R] B) (f h₁ h₂ h₃ h₄ h₅ h₆) : | ||
| (⟨⟨⟨f, e, h₁, h₂⟩, h₃, h₄⟩, h₅, h₆⟩ : B ≃⋆ₐ[R] A) = e.symm := |
There was a problem hiding this comment.
we should still have a version of this (although the current statement is garbage), but only unbundled one level instead of three. That is, (⟨e, h₁, h₂⟩ : A ≃⋆[R] B) where e : A ≃+* B. See RingEquiv.coe_mk and RingEquiv.mk_coe.
So let's note deprecate.
There was a problem hiding this comment.
So, like this?
@[simp]
theorem coe_mk (e h₁ h₂) : ⇑(⟨e, h₁, h₂⟩ : A ≃⋆ₐ[R] B) = e := rfl
@[simp]
theorem mk_coe (e : A ≃⋆ₐ[R] B) (e' h₁ h₂ h₃ h₄ h₅ h₆) :
(⟨⟨⟨e, e', h₁, h₂⟩, h₃, h₄⟩, h₅, h₆⟩ : A ≃⋆ₐ[R] B) = e := ext fun _ => rfl
j-loreaux
added
awaiting-author
This reverts commit 5c78888.
mans0954
changed the title
mk in StarAlgHommk_coe and coe_mk in StarAlgHom
mans0954
added
awaiting-review
and removed
awaiting-author
Import summaryNo significant changes to the import graph |
PR summary ae64441ec3Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
|
Sorry this has been sitting. bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
#13267) Add `mk_coe` and `coe_mk` results to `Algebra/Star/StarAlgHom` in analogy with `RingEquiv`. Co-authored-by: Christopher Hoskin <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mk_coe and coe_mk in StarAlgHommk_coe and coe_mk in StarAlgHom
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
#13267) Add `mk_coe` and `coe_mk` results to `Algebra/Star/StarAlgHom` in analogy with `RingEquiv`. Co-authored-by: Christopher Hoskin <[email protected]>
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
#13267) Add `mk_coe` and `coe_mk` results to `Algebra/Star/StarAlgHom` in analogy with `RingEquiv`. Co-authored-by: Christopher Hoskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
mk_coeandcoe_mkresults toAlgebra/Star/StarAlgHomin analogy withRingEquiv.