Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - style(Mathlib/Tactic/Congr!): rename Congr!.lean to CongrExclamation.lean to avoid the illegal character ! #13280

Closed
wants to merge 3 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented May 27, 2024

I renamed Clear!.lean to ClearExclamation.lean to avoid the illegal character in nixOS: ! in #12757.
However, there is another file which contains !.


Open in Gitpod

@Komyyy Komyyy added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels May 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 1, 2024
@Komyyy Komyyy added awaiting-CI and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

PR summary 2f95d5ad1b

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@YaelDillies
Copy link
Collaborator

Looks reasonable.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@bryangingechen
Copy link
Contributor

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 13, 2024
…on.lean` to avoid the illegal character `!` (#13280)

I renamed `Clear!.lean` to `ClearExclamation.lean` to avoid the illegal character in nixOS: `!` in #12757.
However, there is another file which contains `!`.



Co-authored-by: Pol'tta / Miyahara Kō <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title style(Mathlib/Tactic/Congr!): rename Congr!.lean to CongrExclamation.lean to avoid the illegal character ! [Merged by Bors] - style(Mathlib/Tactic/Congr!): rename Congr!.lean to CongrExclamation.lean to avoid the illegal character ! Jul 13, 2024
@mathlib-bors mathlib-bors bot closed this Jul 13, 2024
@mathlib-bors mathlib-bors bot deleted the Komyyy/Mathlib.Tactic.CongrExclamation branch July 13, 2024 14:36
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants