[Merged by Bors] - chore: Added namespace Mathlib around Vector defs #13407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions which are now fixed
|
Note at this commit : When opening the namespace Mathlib inside the namespace Vector in Topology.List, a number of Vector functions were inferred as List functions and this created errors. I correctly namespaced them |
Shreyas4991
force-pushed
the
feat_namespace_mathlib_vector
branch
from
9e91a8f to
05c3fcf
Compare
Shreyas4991
changed the title
leanprover-community-mathlib4-bot
added
the
merge-conflict
PR summary be5981ac7dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Shreyas4991
changed the title
Shreyas4991
added
awaiting-CI
tech debt
Shreyas4991
force-pushed
the
feat_namespace_mathlib_vector
branch
from
683ad6b to
2235ae5
Compare
Shreyas4991
changed the title
leanprover-community-mathlib4-bot
added
the
merge-conflict
|
LGTM bors d+ Make sure you merge master and CI builds before merging. |
|
✌️ Shreyas4991 can now approve this pull request. To approve and merge a pull request, simply reply with |
Shreyas4991
added
awaiting-CI
and removed
merge-conflict
|
Master has been merged into this PR. CI passes. bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
This PR puts `Mathlib.Data.Vector`'s `Vector` type into the namespace `Mathlib`. This will help ensure that users of `Mathlib` and `Batteries` can use this Vector type and Batteries' upcoming Array based Vector type without name conflicts. Tasks: - [x] Put all Vector definitions, currently all of which are inside Mathlib/Data/Vector into the namespace `Mathlib`. ~~- [x] Add deprecation aliases for all `def`s, `theorem`s and `lemmas` thus namespaced.~~ NOTE : This is not possible because `alias` simply reintroduces naming conflicts. See the linked zulip discussion - [x] Fix breakages within Mathlib Discussion in [Zulip topic](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Mathlib.20Vector.20namespace/near/441643042)
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts
Mathlib.Data.Vector'sVectortype into the namespaceMathlib. This will help ensure that users ofMathlibandBatteriescan use this Vector type and Batteries' upcoming Array based Vector type without name conflicts.Tasks:
Mathlib.- [x] Add deprecation aliases for allNOTE : This is not possible becausedefs,theorems andlemmasthus namespaced.aliassimply reintroduces naming conflicts. See the linked zulip discussionDiscussion in Zulip topic