Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Lie): add Lie's theorem #13480

Closed
wants to merge 85 commits into from

Conversation

Espio231
Copy link
Collaborator

@Espio231 Espio231 commented Jun 3, 2024

Prove Lie's theorem, that Lie modules of solvable Lie algebras over algebraically closed fields of characteristic 0 have a common eigenvector for the action of all elements of the Lie algebra.


Open in Gitpod

@Espio231 Espio231 added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 3, 2024
@Espio231 Espio231 added the help-wanted The author needs attention to resolve issues label Jun 3, 2024
@grunweg
Copy link
Collaborator

grunweg commented Jun 3, 2024

Hello: I'm coming here for issue triage. You marked this PR as help-wanted: can you be more specific what help you need? This makes it easier for other to help you :-)
The lint and build is certainly easy to fix: let me just do this.

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few style comments to get you started (and just pushed the fix to Mathlib.lean, so mathlib's continuous integration can give you feedback).

@grunweg
Copy link
Collaborator

grunweg commented Jun 3, 2024

Oh, and another comment: did you mean to mark this ready for review? If so, feel free to label it awaiting-review once you have addressed my comments. (I've marked it with awaiting-author now: see this page for an explanation what these labels mean: https://leanprover-community.github.io/contribute/index.html)

@grunweg
Copy link
Collaborator

grunweg commented Jun 3, 2024

Last, but not least: thank you for your contribution! I'm very happy that mathlib is learning more about Lie groups and Lie algebras and very much look forward to your result landing, once it's ready!

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 3, 2024
@Espio231 Espio231 removed the help-wanted The author needs attention to resolve issues label Jun 3, 2024
@Espio231
Copy link
Collaborator Author

Espio231 commented Jun 3, 2024

Thank you very much for the help @grunweg. I marked this as help-wanted since I didn't really understand why continuous integration was failing but you seemed to have fixed this now. I'll get to work on resolving the things you've brought up.

@grunweg grunweg added the t-algebra Algebra (groups, rings, fields, etc) label Jun 4, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response! I had some time at my hands and decided to leave a few more comments, mostly about coding style. (This covers perhaps the first half of your PR.)

@grunweg
Copy link
Collaborator

grunweg commented Jun 4, 2024

By the way: once you have dealt with a comment, feel free to mark it as "resolved" in Github. This way, I and future reviews can see which points are still open or not. If you're not sure, leaving it open is fine (but in practice, for many suggestions it's clear once they were resolved).

Copy link

github-actions bot commented Jun 7, 2024

PR summary 02441991c7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Lie.LieTheorem (new file) 1472

Declarations diff

+ exists_nontrivial_weightSpace_of_isNilpotent
+ exists_nontrivial_weightSpace_of_isSolvable
+ exists_nontrivial_weightSpace_of_lieIdeal
+ instance : CanLift (Submodule R M) (LieSubmodule R L M) (·)
+ weightSpaceOfIsLieTower

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already is an api for turning complementary submodules into a direct sum. With my current suggestion, you can remove your pr1 and pr2 declarations.

You may also want to assume IsCompl in more places, instead of separe (Co)Disjoint hypotheses.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 3, 2025
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it looks very nearly ready now.

@ocfnash
Copy link
Contributor

ocfnash commented Jan 4, 2025

I thought a little about this again this morning and I think it might be worth defining a new type BiLieSubmodule (which could go in a new file, naming TBD) and using it to develop things as follows:

variable (R L₁ L₂ M : Type*)
  [CommRing R] [AddCommGroup M] [Module R M]
  [LieRing L₁] [LieAlgebra R L₁] [LieRingModule L₁ M] [LieModule R L₁ M]
  [LieRing L₂] [LieAlgebra R L₂] [LieRingModule L₂ M] [LieModule R L₂ M]

/-- Naming TBD -/
structure BiLieSubmodule extends Submodule R M where
  lie_mem_left : ∀ {x : L₁} {m : M}, m ∈ carrier → ⁅x, m⁆ ∈ carrier
  lie_mem_right : ∀ {x : L₂} {m : M}, m ∈ carrier → ⁅x, m⁆ ∈ carrier

def LieSubmodule.toBiLieSubmodule_of_lieIdeal_left (N : LieSubmodule R L₁ M) (I : LieIdeal R L₁) :
    BiLieSubmodule R I L₁ M :=
  { toSubmodule := N
    lie_mem_left := LieSubmodule.lie_mem _
    lie_mem_right := LieSubmodule.lie_mem _ }

-- Bit more API for BiLieSubmodule, including coercions to `LieSubmodule R Lᵢ M` etc

/-- The non-trivial result justifying the `BiLieSubmodule` concept. -/
def biWeightSpaceLeft [IsPrincipalIdealRing R] [IsDomain R] [CharZero R]
    [Module.Free R M] [Module.Finite R M]
    [Bracket L₁ L₂] [Bracket L₂ L₁] [IsLieTower L₁ L₂ M] [IsLieTower L₂ L₁ M]
    (χ : L₁ → R) :
    BiLieSubmodule R L₁ L₂ M :=
  { toSubmodule := weightSpace M χ
    lie_mem_left := LieSubmodule.lie_mem _
    lie_mem_right x {m} hm := lie_stable χ x m hm /- modulo renaming of `lie_stable` -/ }

@ocfnash
Copy link
Contributor

ocfnash commented Jan 4, 2025

Another passing thought is that maybe this BiLieSubmodule idea is silly and what we really have is LieSubmodule R (L₁ × L₂) M. I just tried to check this in Lean and annoyingly we don't have the basic theory of binary products of Lie algebras (and their representations). On paper the calculation also didn't work out but I feel like this is still worth some thought. Unfortunately I probably won't have time.

I also don't think it is necessary to use my various suggestions from this morning. Clearly things are in reasonable shape; it's just that I'd like to feel like I understand the true content of Lie's theorem.

@jcommelin
Copy link
Member

it's just that I'd like to feel like I understand the true content of Lie's theorem.

This resonates with me a lot. I still feel like I haven't found the ultimate proof. But after many iterations, I'm out of ideas for finding a better version than the current one.

@jcommelin jcommelin removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 4, 2025
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all this work both @Espio231 for the original result and @jcommelin for a heroic effort getting it ready for Mathlib!

Apart from minor naming issues (for which I think I am responsible 🤦 ) I think this is ready to go.

If I get time in the weeks ahead, I may try to find some other points of view since although I follow the argument, I don't really feel I understand the true content.

Anyway, this is great.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 4, 2025

✌️ Espio231 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ocfnash
Copy link
Contributor

ocfnash commented Jan 4, 2025

bors d=@jcommelin

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 4, 2025

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin
Copy link
Member

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 4, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 4, 2025
Prove Lie's theorem, that Lie modules of solvable Lie algebras over algebraically closed fields of characteristic 0 have a common eigenvector for the action of all elements of the Lie algebra.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 4, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Lie): add Lie's theorem [Merged by Bors] - feat(Algebra/Lie): add Lie's theorem Jan 4, 2025
@mathlib-bors mathlib-bors bot closed this Jan 4, 2025
@mathlib-bors mathlib-bors bot deleted the lwhitfield-Lie-theorem branch January 4, 2025 18:55
Julian added a commit that referenced this pull request Jan 5, 2025
* origin/master: (133 commits)
  chore(1000): remove nonexistent fields (#20493)
  chore(CategoryTheory/Adjunction.Basic, CategoryTheory/Equivalence): change definition of `Adjunction.comp` and `Equivalence.trans` (#20490)
  feat(Asymptotics): add `Asymptotics.*.*Prod` lemmas (#20458)
  feat: a conditional kernel is almost everywhere a probability measure (#20430)
  feat: if `f` is a measurable group hom, then every point has a neighborhood `s` such that `f '' s` is bounded (#20304)
  feat: `Ico`, `Ioc`, and `Ioo` are not closed or compact (#20479)
  chore: drop redundant hypothesis in `Module.Dual.eq_of_preReflection_mapsTo` (#20492)
  feat(FaaDiBruno): derive `DecidableEq` (#20482)
  chore(SetTheory/Ordinal/Basic): `{x // x < y}` → `Iio y` (#20413)
  chore: generalize `FormalMultilinearSeries.ofScalars_norm` to `Seminormed` (#20351)
  chore(MvPolynomial/Localization): golf using TensorProduct (#20309)
  chore(Combinatorics/Enumerative/Partition): auto-derive DecidableEq (#20277)
  chore(CategoryTheory): make relevant parameters explicit in `Arrow.homMk`. (#20259)
  feat: add `IsStarNormal (↑x⁻¹ : R)` instance for `x : Rˣ` (#20091)
  fix: Stop cancelling builds of master (#20435)
  chore: update Mathlib dependencies 2025-01-05 (#20485)
  feat(SetTheory/Cardinal/Arithmetic): miscellaneous cardinality lemmas (#18933)
  chore: bump toolchain to v4.16.0-rc1, and merge bump/v4.16.0 (#20464)
  chore: bot validates lean-toolchain on bump/v4.X.0 branches (#20478)
  feat: shorthand lemmas for the L1 norm (#20383)
  chore: remove unnecessary adaptation notes (#20467)
  chore(Algebra/Category/MonCat/Colimits): remove smallness condition (#20473)
  chore(SetTheory/Ordinal/Arithmetic): `IsLeftCancelAdd Ordinal` (#19888)
  feat(Algebra): more on `OrthogonalIdempotents` (#18195)
  feat(Radical): `(radical a).natDegree ≤ a.natDegree` (#20468)
  feat(Polynomial): `(a^n)' = 0` iff `a' = 0` when `n` doesn't divide the characteristic (#20190)
  feat(Algebra/Lie): add Lie's theorem (#13480)
  chore(RingTheory/Generators): make algebra instance a def (#14265)
  feat(Topology/Group): Lemmas about profinite group (#20282)
  feat: the empty set is a topological basis iff the space is empty (#20441)
  chore: make uniqueness of conditionally complete linearly ordered archimedean fields independent of the construction of `Real` (#20242)
  chore: `inherit_doc`s for notations (#20376)
  chore: split AEEqOfIntegral into two files, one for each integral type (#20405)
  chore: split Kernel/MeasurableIntegral (#20427)
  feat(MeasureTheory/Group/Measure): add ContinuousMulEquiv.isHaarMeasure_map (#20469)
  fix(Mathlib.Tactic.CC.Datatypes): `cc` raises panic (#20422)
  feat(Probability/Moments): add lemmas about moment generating functions (#19886)
  feat(Algebra/Order/AddGroupWithTop): lemmas about LinearOrderedAddCommGroupWithTop (#18954)
  chore: bump toolchain to v4.15.0 (#20461)
  chore: update Mathlib dependencies 2025-01-04 (#20463)
  fix: make `Prod` projection delaborators respond to options, add option to disable (#20455)
  chore(Algebra): Improve attribute generation (#20451)
  feat(Polynomial): `(C a * p).degree = p.degree` if `a * p.leadingCoeff ≠ 0` (#20446)
  feat: add `ENNReal.finStronglyMeasurable_of_measurable` (#20404)
  doc(Algebra/Lie/Weights/Basic): fix typo (#20450)
  chore(1000): remove `identifiers` (#20445)
  feat: add sumPiEquivProdPi and piUnique (#20195)
  feat: add fst_compProd_apply (#20429)
  chore: use unsigned measures for Lebesgue decomposition (#20400)
  feat: Two lemmas on divisibility and coprimality of `expand` (#20143)
  ...
Julian added a commit that referenced this pull request Jan 6, 2025
* origin/master: (189 commits)
  chore(Algebra): make more names consistent (#20449)
  feat: Polynomial FLT (#18882)
  feat: A disjoint union is finite iff all sets are finite, and all but finitely many are empty (#20457)
  fix: linkfix in 100.yaml (#20517)
  feat(1000): fill in more entries (#20470)
  feat(Combinatorics/SimpleGraph/Walk): add `penultimate` and `snd` (#16769)
  feat(ContinuousMultilinearMap): add lemmas about `.prod` (#20462)
  feat(RingTheory): classification of etale algebras over fields (#20324)
  fix: Allow multiple builds on staging branch (#20515)
  feat(CategoryTheory/Shift/Adjunction): properties of `Adjunction.CommShift` (#20337)
  chore(Data/Multiset/Basic): move the `sub`, `union`, `inter` sections lower (#19863)
  chore(Topology/UniformSpace/Completion): make coe' argument implicit (#20514)
  refactor(Algebra/Category/Grp/Colimits): change the construction of colimits in `AddCommGrp` (#20474)
  feat(Topology/Algebra/InfiniteSum/NatInt): Add pnat lems (#16544)
  chore(RingTheory/Finiteness): rename Module.Finite.out (#20506)
  refactor(CategoryTheory/Limits/Preserves/Ulift): simplify the proof that the universe lifting functor for types preserves all colimits (#20508)
  feat(CategoryTheory): products in the category of Ind-objects (#20507)
  chore: remove >9 month old deprecations (#20505)
  chore(FieldTheory/Galois): small cleanup (#20217)
  chore(LinearIndependent): generalize to semirings (#20480)
  chore(NumberTheory/NumberField/AdeleRing): refactor adele rings (#20500)
  chore: replace `aesop` with `simp` where possible (#20483)
  chore(1000): remove nonexistent fields (#20493)
  chore(CategoryTheory/Adjunction.Basic, CategoryTheory/Equivalence): change definition of `Adjunction.comp` and `Equivalence.trans` (#20490)
  feat(Asymptotics): add `Asymptotics.*.*Prod` lemmas (#20458)
  feat: a conditional kernel is almost everywhere a probability measure (#20430)
  feat: if `f` is a measurable group hom, then every point has a neighborhood `s` such that `f '' s` is bounded (#20304)
  feat: `Ico`, `Ioc`, and `Ioo` are not closed or compact (#20479)
  chore: drop redundant hypothesis in `Module.Dual.eq_of_preReflection_mapsTo` (#20492)
  feat(FaaDiBruno): derive `DecidableEq` (#20482)
  chore(SetTheory/Ordinal/Basic): `{x // x < y}` → `Iio y` (#20413)
  chore: generalize `FormalMultilinearSeries.ofScalars_norm` to `Seminormed` (#20351)
  chore(MvPolynomial/Localization): golf using TensorProduct (#20309)
  chore(Combinatorics/Enumerative/Partition): auto-derive DecidableEq (#20277)
  chore(CategoryTheory): make relevant parameters explicit in `Arrow.homMk`. (#20259)
  feat: add `IsStarNormal (↑x⁻¹ : R)` instance for `x : Rˣ` (#20091)
  fix: Stop cancelling builds of master (#20435)
  chore: update Mathlib dependencies 2025-01-05 (#20485)
  feat(SetTheory/Cardinal/Arithmetic): miscellaneous cardinality lemmas (#18933)
  chore: bump toolchain to v4.16.0-rc1, and merge bump/v4.16.0 (#20464)
  chore: bot validates lean-toolchain on bump/v4.X.0 branches (#20478)
  feat: shorthand lemmas for the L1 norm (#20383)
  chore: remove unnecessary adaptation notes (#20467)
  chore(Algebra/Category/MonCat/Colimits): remove smallness condition (#20473)
  chore(SetTheory/Ordinal/Arithmetic): `IsLeftCancelAdd Ordinal` (#19888)
  feat(Algebra): more on `OrthogonalIdempotents` (#18195)
  feat(Radical): `(radical a).natDegree ≤ a.natDegree` (#20468)
  feat(Polynomial): `(a^n)' = 0` iff `a' = 0` when `n` doesn't divide the characteristic (#20190)
  feat(Algebra/Lie): add Lie's theorem (#13480)
  chore(RingTheory/Generators): make algebra instance a def (#14265)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Development

Successfully merging this pull request may close these issues.

7 participants