-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Order): Galois connection between pred
and succ
#13505
Conversation
This was a longstanding TODO. Kudos to Kevin for putting the pieces together!
PR summary 2056d7f81d
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Order.SuccPred.Basic | 341 | 342 | +1 (+0.29%) |
Import changes for all files
Files | Import difference |
---|---|
8 filesMathlib.Order.Grade Mathlib.Data.ENat.Basic Mathlib.Order.SuccPred.Basic Mathlib.Data.Nat.SuccPred Mathlib.Order.SuccPred.Relation Mathlib.Order.SuccPred.Limit Mathlib.Data.Fin.SuccPred Mathlib.Data.Int.SuccPred |
1 |
Declarations diff
+ WCovBy.covBy_or_le_and_le
+ _
+ _root_.IsMax.of_succ_le
+ _root_.IsMax.succ_le
+ _root_.IsMin.le_pred
+ _root_.IsMin.of_le_pred
+ _root_.LT.lt.le_pred
+ _root_.LT.lt.succ_le
+ gc_pred_succ
+ le_succ_of_wcovBy
+ le_succ_pred
+ pred_eq_of_covBy
+ pred_le_iff_le_succ
+ pred_le_of_wcovBy
+ pred_succ_le
+ succ_eq_of_covBy
- SuccPredOrder
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Only hesitation is the import increase, otherwise LGTM. Happy if someone wants to merge regardless, or to ask for a split. |
As the author of |
bors merge |
Pull request successfully merged into master. Build succeeded: |
pred
and succ
pred
and succ
This was a longstanding TODO. Kudos to Kevin for putting the pieces together!