Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Order): Galois connection between pred and succ #13505

Closed
wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

This was a longstanding TODO. Kudos to Kevin for putting the pieces together!


Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 5, 2024
@YaelDillies YaelDillies added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 6, 2024
This was a longstanding TODO. Kudos to Kevin for putting the pieces together!
Copy link

github-actions bot commented Jul 6, 2024

PR summary 2056d7f81d

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.SuccPred.Basic 341 342 +1 (+0.29%)
Import changes for all files
Files Import difference
8 files Mathlib.Order.Grade Mathlib.Data.ENat.Basic Mathlib.Order.SuccPred.Basic Mathlib.Data.Nat.SuccPred Mathlib.Order.SuccPred.Relation Mathlib.Order.SuccPred.Limit Mathlib.Data.Fin.SuccPred Mathlib.Data.Int.SuccPred
1

Declarations diff

+ WCovBy.covBy_or_le_and_le
+ _
+ _root_.IsMax.of_succ_le
+ _root_.IsMax.succ_le
+ _root_.IsMin.le_pred
+ _root_.IsMin.of_le_pred
+ _root_.LT.lt.le_pred
+ _root_.LT.lt.succ_le
+ gc_pred_succ
+ le_succ_of_wcovBy
+ le_succ_pred
+ pred_eq_of_covBy
+ pred_le_iff_le_succ
+ pred_le_of_wcovBy
+ pred_succ_le
+ succ_eq_of_covBy
- SuccPredOrder

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Contributor

kim-em commented Jul 15, 2024

Only hesitation is the import increase, otherwise LGTM. Happy if someone wants to merge regardless, or to ask for a split.

@YaelDillies
Copy link
Collaborator Author

As the author of Order.SuccPred.Basic, I claim this import increase is fine 😄

@kim-em
Copy link
Contributor

kim-em commented Jul 16, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
This was a longstanding TODO. Kudos to Kevin for putting the pieces together!
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order): Galois connection between pred and succ [Merged by Bors] - feat(Order): Galois connection between pred and succ Jul 17, 2024
@mathlib-bors mathlib-bors bot closed this Jul 17, 2024
@mathlib-bors mathlib-bors bot deleted the gc_pred_succ branch July 17, 2024 00:26
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants