-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: add unitor functor for product of categories #13663
Conversation
PR summary 9f3684242aImport changesNo significant changes to the import graph
|
Thanks for the contribution! If you think this PR is ready for review please add the "awaiting-review" label. While you're at it, adding the "t-category-theory" tag also helps the discoverability of the PR. Also see this page for more info. |
@erdOne Thank you for the reply! Yeah I added the two tags and reading the doc now. |
As the file is named |
@joelriou Thank you for the suggestion! New code moved to a new file |
You may have to update the root file |
@joelriou Thanks for the reminding! |
1dffc8e
to
e0140c0
Compare
e0140c0
to
5d00bfe
Compare
|
||
/-- The left unitor functor `1 × C ⥤ C` -/ | ||
@[simps] | ||
def leftUnitor : Discrete (PUnit: Type w) × C ⥤ C where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And similarly below:
def leftUnitor : Discrete (PUnit: Type w) × C ⥤ C where | |
def leftUnitor : Discrete (PUnit : Type w) × C ⥤ C where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Codestyle change with space before column now
Thanks! bors merge |
left and right unitor functors for product of categories Co-authored-by: Shanghe Chen <[email protected]>
Pull request successfully merged into master. Build succeeded: |
left and right unitor functors for product of categories Co-authored-by: Shanghe Chen <[email protected]>
left and right unitor functors for product of categories Co-authored-by: Shanghe Chen <[email protected]>
left and right unitor functors for product of categories
The implementation is copying from the same file for the associator. I am not sure if the category "1" , i.e.,
Discrete Punit
should take universe parameter or not, and if it should have some notation like U+1D7CF 𝟏 or something else.