Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: reverse gdelta/separation dependency #13694

Closed
wants to merge 5 commits into from

Conversation

StevenClontz
Copy link
Collaborator

@StevenClontz StevenClontz commented Jun 10, 2024

This reversal will allow for the following definition for a perfectly normal space (with $T_1$ this is T_6, the last "whole number" separation axiom missing from mathlib), proposed at #13517.

/-- A topological space `X` is a *perfectly normal space* provided it is normal and
closed sets are Gδ. -/
class PerfectlyNormalSpace (X : Type u) [TopologicalSpace X] extends NormalSpace X : Prop where
    closed_gdelta : ∀ ⦃h : Set X⦄, IsClosed h → IsGδ h

Open in Gitpod

Copy link

github-actions bot commented Jun 10, 2024

PR summary b24f7e4def

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.GDelta 630 612 -18 (-2.86%)
Mathlib.Topology.Separation 624 630 +6 (+0.96%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@StevenClontz StevenClontz added WIP Work in progress t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jun 10, 2024
@StevenClontz StevenClontz marked this pull request as ready for review June 10, 2024 18:45
@StevenClontz StevenClontz added awaiting-review and removed WIP Work in progress labels Jun 10, 2024
@StevenClontz StevenClontz marked this pull request as draft June 10, 2024 23:36
@StevenClontz StevenClontz marked this pull request as ready for review June 13, 2024 02:13
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 26, 2024
This reversal will allow for the following definition for a [perfectly normal](https://topology.pi-base.org/properties/P15) space (with $T_1$ this is [T_6](https://topology.pi-base.org/properties/P000067), the last "whole number" separation axiom missing from mathlib), proposed at #13517.

```lean
/-- A topological space `X` is a *perfectly normal space* provided it is normal and
closed sets are Gδ. -/
class PerfectlyNormalSpace (X : Type u) [TopologicalSpace X] extends NormalSpace X : Prop where
    closed_gdelta : ∀ ⦃h : Set X⦄, IsClosed h → IsGδ h
```
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: reverse gdelta/separation dependency [Merged by Bors] - chore: reverse gdelta/separation dependency Jun 26, 2024
@mathlib-bors mathlib-bors bot closed this Jun 26, 2024
@mathlib-bors mathlib-bors bot deleted the StevenClontz/gdelta branch June 26, 2024 01:52
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
This reversal will allow for the following definition for a [perfectly normal](https://topology.pi-base.org/properties/P15) space (with $T_1$ this is [T_6](https://topology.pi-base.org/properties/P000067), the last "whole number" separation axiom missing from mathlib), proposed at #13517.

```lean
/-- A topological space `X` is a *perfectly normal space* provided it is normal and
closed sets are Gδ. -/
class PerfectlyNormalSpace (X : Type u) [TopologicalSpace X] extends NormalSpace X : Prop where
    closed_gdelta : ∀ ⦃h : Set X⦄, IsClosed h → IsGδ h
```
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
This reversal will allow for the following definition for a [perfectly normal](https://topology.pi-base.org/properties/P15) space (with $T_1$ this is [T_6](https://topology.pi-base.org/properties/P000067), the last "whole number" separation axiom missing from mathlib), proposed at #13517.

```lean
/-- A topological space `X` is a *perfectly normal space* provided it is normal and
closed sets are Gδ. -/
class PerfectlyNormalSpace (X : Type u) [TopologicalSpace X] extends NormalSpace X : Prop where
    closed_gdelta : ∀ ⦃h : Set X⦄, IsClosed h → IsGδ h
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants