-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat : define ContinuousFunctionalCalculus
Instance for Hermitian Matrices over an RCLike Field
#13697
Conversation
…but it isn't that bad.
…oint of this is to access the lemmas jireh proved to shorten a proof
Weird let me have a look.
…On Sat, Jul 6, 2024, 11:55 AM Jireh Loreaux ***@***.***> wrote:
@JonBannon <https://github.com/JonBannon> build still falling
—
Reply to this email directly, view it on GitHub
<#13697 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJJJTTBBW6W652HF3X5AR3ZLAHOVAVCNFSM6AAAAABJCYSOLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHAYDGOJUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Looks like I have to put HermitianFunctionalCalculus.lean into the Mathlib
file...because we created a new file. I'll bet that's what is happening.
J
…On Sat, Jul 6, 2024 at 12:18 PM Bannon, Jon ***@***.***> wrote:
Weird let me have a look.
On Sat, Jul 6, 2024, 11:55 AM Jireh Loreaux ***@***.***>
wrote:
> @JonBannon <https://github.com/JonBannon> build still falling
>
> —
> Reply to this email directly, view it on GitHub
> <#13697 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOJJJTTBBW6W652HF3X5AR3ZLAHOVAVCNFSM6AAAAABJCYSOLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHAYDGOJUGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
… not in the build. Perhaps the master version this is built on has diverged from the current version of master?
… the missing predicate_zero. No need for any new imports, so we have only 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more style and documentation nits.
@dupuisf I'll need you (or another reviewer, but you make the most sense I think) to take over here, because I've contributed too much to even feel comfortable putting it on the maintainer merge-queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
bors d+
✌️ JonBannon can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
…atrices over an RCLike Field (#13697) This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field. - [x] depends on: #13729 - [x] depends on: #13765 - [x] depends on : #13837 - [x] depends on : #13838 Co-Authored by @j-loreaux Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Frédéric Dupuis <[email protected]>
Canceled. |
bors r+ |
…atrices over an RCLike Field (#13697) This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field. - [x] depends on: #13729 - [x] depends on: #13765 - [x] depends on : #13837 - [x] depends on : #13838 Co-Authored by @j-loreaux Co-authored-by: JonBannon <[email protected]> Co-authored-by: Jireh Loreaux <[email protected]>
Pull request successfully merged into master. Build succeeded: |
ContinuousFunctionalCalculus
Instance for Hermitian Matrices over an RCLike FieldContinuousFunctionalCalculus
Instance for Hermitian Matrices over an RCLike Field
This file contains the requisite lemmas needed to define a
ContinuousFunctionalCalculus
for Hermitian Matrices over an RCLike Field.spectrum.conjugate_units
results toAlgebra.Algebra.Spectrum
, andspectrum.conjugate_unitary
results toAlgebra.Star.Unitary
. #13729Module.End.finite_spectrum
andMatrix.finite_spectrum
#13765eigenvalues_mem_spectrum_real
and supporting RCLike coercion results #13838Co-Authored by @j-loreaux