Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat : define ContinuousFunctionalCalculus Instance for Hermitian Matrices over an RCLike Field #13697

Closed
wants to merge 166 commits into from

Conversation

…oint of this is to access the lemmas jireh proved to shorten a proof
@JonBannon
Copy link
Collaborator Author

JonBannon commented Jul 6, 2024 via email

@JonBannon
Copy link
Collaborator Author

JonBannon commented Jul 6, 2024 via email

Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more style and documentation nits.

@j-loreaux j-loreaux requested a review from dupuisf July 8, 2024 12:41
@j-loreaux
Copy link
Collaborator

@dupuisf I'll need you (or another reviewer, but you make the most sense I think) to take over here, because I've contributed too much to even feel comfortable putting it on the maintainer merge-queue.

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 8, 2024
@JonBannon JonBannon added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 8, 2024
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

✌️ JonBannon can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@JonBannon
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
…atrices over an RCLike Field (#13697)

This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field.

- [x] depends on: #13729
- [x] depends on: #13765
- [x] depends on : #13837
- [x] depends on : #13838

Co-Authored by @j-loreaux



Co-authored-by: Jireh Loreaux <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Canceled.

@JonBannon
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
…atrices over an RCLike Field (#13697)

This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field.

- [x] depends on: #13729
- [x] depends on: #13765
- [x] depends on : #13837
- [x] depends on : #13838

Co-Authored by @j-loreaux



Co-authored-by: JonBannon <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat : define ContinuousFunctionalCalculus Instance for Hermitian Matrices over an RCLike Field [Merged by Bors] - feat : define ContinuousFunctionalCalculus Instance for Hermitian Matrices over an RCLike Field Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the HermitianMatrixFunctionalCalculus branch July 9, 2024 02:10
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants