-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: remove unnecessary term or tactic set_option in
with backwards-compatibility flags
#13704
Conversation
Not exhaustive; there are 15 remaining occurrences which presumably can be mostly removed. 'in decide' or so is also relevant.
set_option tactic.skipAssignedInstances false in The remaining instances in mathlib are commands (most of them) or actually still necessary.
PR summary 66bd80bbd0Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
!bench |
Here are the benchmark results for commit 8bb74a8. Benchmark Metric Change
=================================================================
- ~Mathlib.RingTheory.Polynomial.ScaleRoots instructions 49.6% |
Lesson learned: these options can be performance-sensitive. Reverted the |
|
I looked at the files which slowed down by more than 10^9 instructions. So, let's re-benchmark this! |
!bench |
Here are the benchmark results for commit 66bd80b. |
General information: 1 file got slower by at least 10⁹ instructions: No file got slower by at least 10%. 3 files got faster by at least 10⁹ instructions:
No file got faster by at least 10%. |
bors merge |
Already running a review |
bors merge |
Pull request successfully merged into master. Build succeeded: |
set_option in
with backwards-compatibility flagsset_option in
with backwards-compatibility flags
As far as I can tell, this removes all
set_option ... false in norm_num
🎉Inspired by the linter in #13653 (but not covered by it yet; so far, that linter only checks the set_option command).