Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Rename Equiv.forall_congr lemmas #13725

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

These names were all over the place and there were missing versions.


Open in Gitpod

These names were all over the place and there were missing versions.
Copy link

github-actions bot commented Jun 11, 2024

PR summary e8cbf3d9cd

Import changes

No significant changes to the import graph


Declarations diff

+ existsUnique_congr'
+ existsUnique_congr_left
+ existsUnique_congr_right
+ exists_congr
+ exists_congr'
+ exists_congr_right
+ forall_congr_right
++ existsUnique_congr
- exists_unique_congr_left
- exists_unique_congr_left'
- forall_congr_left'
-- exists_unique_congr

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@YaelDillies
Copy link
Collaborator Author

@adomani, the above diff is wrong. It seems like it is ignoring the alias.

@adomani
Copy link
Collaborator

adomani commented Jun 11, 2024

If


+ exists_congr
+ exists_congr'
+ exists_congr_right
+-- exists_unique_congr
+ existsUnique_congr'
++ existsUnique_congr
+ existsUnique_congr_left
+ existsUnique_congr_right
+ forall_congr_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

looks more correct, then #13731 is the PR making the change!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 26, 2024
These names were all over the place and there were missing versions.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Rename Equiv.forall_congr lemmas [Merged by Bors] - chore: Rename Equiv.forall_congr lemmas Jun 26, 2024
@mathlib-bors mathlib-bors bot closed this Jun 26, 2024
@mathlib-bors mathlib-bors bot deleted the forall_exists_congr branch June 26, 2024 13:40
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
These names were all over the place and there were missing versions.
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
These names were all over the place and there were missing versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants