-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: address @[pp_nodot]
porting notes
#13781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 403173893aImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
joneugster
approved these changes
Jun 12, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
TwoFX
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`). closes #11180
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`). closes #11180
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Pull request successfully merged into master. Build succeeded: |
@[pp_nodot]
porting notes@[pp_nodot]
porting notes
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`). closes #11180
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Adds in `@[pp_nodot]` wherever there was a porting note, except in some cases where by principle it can never have an affect (such as for `MulOpposite.op` or `SymAlg.sym`). closes #11180
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
into the respective files: essentially dissolves the `FunProp/Measurable` and `AEMeasurable` files. (The latter is kept to note two missing statements. It is not imported anywhere any more.) This is a pre-requisite for #13781, so fun_prop can be used without breaking existing the `assert_not_exists` statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in
@[pp_nodot]
wherever there was a porting note, except in some cases where by principle it can never have an affect (such as forMulOpposite.op
orSymAlg.sym
).closes #11180