-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(NumberTheory/EllipticDivisibilitySequence): extend even-odd recursion to integers #13786
Conversation
…acobian.Representative
…ve.Jacobian.Point
@Multramate please remember to mark old conversations as resolved. If they are left unresolved it is hard for a new reviewer coming in to understand the status of the PR. |
They're resolved in the sense that I still intend to move forward with this PR (despite #13057), but they're not resolved in the sense that @alreadydone hasn't explicitly agreed to this. Note that #13057 will take a while to get merged, while this is essentially standalone, and I think it's fine to have this easy proof early on without relying on that. |
@alreadydone I have been assigned this PR and am having a look. Can you perform another round of revision? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update your doc by using unicode characters for all latex codes? Although MathJax will probably render them nicely in a browser, they're still pretty unreadable in VSCode, and if you use unicode things are much more readable. Thanks!
Mathlib/AlgebraicGeometry/EllipticCurve/DivisionPolynomial/Basic.lean
Outdated
Show resolved
Hide resolved
split_ifs <;> C_simp <;> rw [C_Ψ₂Sq] <;> ring1 | ||
|
||
lemma Ψ_even (m : ℕ) : W.Ψ (2 * (m + 3)) * W.ψ₂ = | ||
lemma Ψ_even' (m : ℕ) : W.Ψ (2 * (m + 3)) * W.ψ₂ = | ||
W.Ψ (m + 2) ^ 2 * W.Ψ (m + 3) * W.Ψ (m + 5) - W.Ψ (m + 1) * W.Ψ (m + 3) * W.Ψ (m + 4) ^ 2 := by | ||
repeat erw [Ψ_ofNat] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is erw
needed? Is there perhaps a bit of API missing, making rw
work smoothly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these are just for the sake of my sanity, e.g. converting 4 - 1 to 3 by rw [show (4 - 1 : ℤ) = 3 by rfl]
etc.
I can add these to the bottom of this file though, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I have to find a different home for those lemmas, since I don't think file imports AddGroup
...
Mathlib/AlgebraicGeometry/EllipticCurve/DivisionPolynomial/Basic.lean
Outdated
Show resolved
Hide resolved
@faenuccio just to be clear, would we prefer something like this instead?
|
If you're asking with regard to the unicode business, then yes: I find this much more readable. |
Mathlib/AlgebraicGeometry/EllipticCurve/DivisionPolynomial/Basic.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicGeometry/EllipticCurve/DivisionPolynomial/Degree.lean
Outdated
Show resolved
Hide resolved
maintainer merge |
🚀 Pull request has been placed on the maintainer queue by faenuccio. |
Thanks! bors merge |
Pull request successfully merged into master. Build succeeded: |
Provide a quick proof that normalised EDSs satisfy an even-odd recursion over all integers rather than just natural numbers, without relying on heavier machinery i.e. the full EDS recurrence in #13155, and make
Int.negInduction
slightly stronger.