-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EllipticCurve): the universal elliptic curve #13847
base: master
Are you sure you want to change the base?
Conversation
PR summary 44f983a8faImport changesNo significant changes to the import graph
|
…mmunity/mathlib4 into EllCurve/universal
Thanks! I think I said somewhere (but I've lost it!) that I intend to combine stuff from this file with all the stuff to do with the coordinate ring, because I would think that these are "universal constructions" for any Weierstrass curve. I haven't had the time to do it so far, but can you give me some time to think about it? I'll make a subbranch (hopefully I don't mess it up again!). |
I think you said it here. Yes I agree that for a Weierstrass curve W over comm. ring R you can define a "universal" Weierstrass curve over the coordinate ring R[W] with a distinguished point (X,Y) on it, such that every point (x,y) on W is the specialization of the distinguished point under the ring homomorphism R[W]->R sending X to x and Y to y. As I remarked here, you can almost prove the ZSMul formula using this less universal ring, but it would not be so easy to show ψₙ ≠ 0 when n ≠ 0 if the characteristic divides n, and in char 2 there's an additional issue. I'll try to refactor my code with generalized definitions, thanks for mentioning this! |
This PR/issue depends on: |
Define the universal Weierstrass curve (
Universal.curve
) over the polynomial ringℤ[A₁,A₂,A₃,A₄,A₆]
, and the universal pointed elliptic curve (Universal.pointedCurve
) over the field of fractions (Universal.Field
) of the universal ringℤ[A₁,A₂,A₃,A₄,A₆,X,Y]/⟨P⟩ = Universal.Poly/⟨P⟩
(Universal.Ring
, whereP
is the Weierstrass polynomial) with distinguished point(X,Y)
.Given a Weierstrass curve
W
over a commutative ringR
, we define the specialization homomorphismW.specialize : ℤ[A₁,A₂,A₃,A₄,A₆] →+* R
. If(x,y)
is a point on the affine plane, we defineW.polyEval x y : Universal.Poly →+* R
, which factors throughW.ringEval x y : Universal.Ring →+* R
if(x,y)
is onW
.Introduce the cusp curve
Y² = X³
, on which lies the rational point(1,1)
, with the nice property thatψₙ(1,1) = n
, making it easy to prove nonvanishing of the universalψₙ
whenn ≠ 0
by specializing to the cusp curve, which shows that(X,Y)
is a point of infinite order on the universal pointed elliptic curve.