[Merged by Bors] - fix: add -lLake argument to pole and mk_all
#13850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Lean 4.9, the behaviour of supportInterpreter executables has changed, makes this necessary: both of these executables require modules from lake, while does not.
grunweg
added
awaiting-review
CI
PR summary 55b39bd4e8Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
grunweg
changed the title
-lLake argument to pole and mk_all
|
On zulip, @Rida-Hamadani reports successfully testing this on windows. |
|
It succeeds only after deleting |
kim-em
reviewed
Jun 25, 2024
|
bors d+ |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
grunweg
commented
Jun 25, 2024
Co-authored-by: Kim Morrison <[email protected]>
|
Thanks for the review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
Since Lean 4.9, the behaviour of `supportInterpreter` executables has changed, making this necessary: both of these executables require modules from `lake`. In contrast, `shake` also uses `supportInterpreter`, but does not depend on `lake`. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/automatically.20generate.20ProjectName.2Elean/near/444239597)
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
-lLake argument to pole and mk_all-lLake argument to pole and mk_all
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
Since Lean 4.9, the behaviour of `supportInterpreter` executables has changed, making this necessary: both of these executables require modules from `lake`. In contrast, `shake` also uses `supportInterpreter`, but does not depend on `lake`. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/automatically.20generate.20ProjectName.2Elean/near/444239597)
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Since Lean 4.9, the behaviour of `supportInterpreter` executables has changed, making this necessary: both of these executables require modules from `lake`. In contrast, `shake` also uses `supportInterpreter`, but does not depend on `lake`. [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/automatically.20generate.20ProjectName.2Elean/near/444239597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Lean 4.9, the behaviour of
supportInterpreterexecutables has changed, making this necessary:both of these executables require modules from
lake.In contrast,
shakealso usessupportInterpreter, but does not depend onlake.zulip discussion