Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - perf(DoldKan/EquivalencePseudoabelian): use suppress_compilation #13858

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jun 15, 2024

Compiling the file takes 14s; the computability is not used anywhere in mathlib.
Speeds up the file by 78%.


Open in Gitpod

Compiling the file takes 14s --- is computability useful?
@grunweg
Copy link
Collaborator Author

grunweg commented Jun 15, 2024

CC @joelriou I'm interested in your opinion here: is there a downside to this change I'm not seeing?

Copy link

PR summary 83efb54ba8

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.AlgebraicTopology.DoldKan.EquivalencePseudoabelian 967 970 +3 (+0.31%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@grunweg
Copy link
Collaborator Author

grunweg commented Jun 15, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 83efb54.
There were significant changes against commit f9ab934:

  Benchmark                                                     Metric         Change
  ===================================================================================
+ ~Mathlib.AlgebraicTopology.DoldKan.EquivalencePseudoabelian   instructions   -77.9%

@grunweg grunweg changed the title perf(DoldKan/EquivalencePseudoabelian): suppress compilation perf(DoldKan/EquivalencePseudoabelian): use suppress_compilation Jun 15, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 1, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
)

Compiling the file takes 14s; the computability is not used anywhere in mathlib.
Speeds up the file by 78%.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
)

Compiling the file takes 14s; the computability is not used anywhere in mathlib.
Speeds up the file by 78%.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title perf(DoldKan/EquivalencePseudoabelian): use suppress_compilation [Merged by Bors] - perf(DoldKan/EquivalencePseudoabelian): use suppress_compilation Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the MR-suppress-compilation-doldkan branch July 1, 2024 11:37
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
)

Compiling the file takes 14s; the computability is not used anywhere in mathlib.
Speeds up the file by 78%.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants