[Merged by Bors] - chore/perf(Probability/MeasureTheory): use fun_prop for manual measurability calls
#13871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the respective files So fun_prop can be used without breaking existing assert_not_exists statements.
tagging the minimal number of lemmas.
… to its proper place
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR summary 3ef23cd541Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
grunweg
force-pushed
the
MR-replace-slow-measurability-funprop
branch
from
f5c5ca1 to
9824e37
Compare
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
|
!bench |
|
Here are the benchmark results for commit 7cce133. Benchmark Metric Change
==========================================================================
+ ~Mathlib.Analysis.SpecialFunctions.JapaneseBracket instructions -64.8% |
leanprover-community-mathlib4-bot
added
merge-conflict
|
This PR/issue depends on: |
…should one tag continuous_norm instead?
grunweg
commented
Jun 24, 2024
| -- TODO(#13864): reinstate faster automation, e.g. by making `fun_prop` work here | ||
| exact (((Measure.measurable_rnDeriv _ μ | ||
| ).ennreal_toNNReal).coe_nnreal_real).aestronglyMeasurable | ||
| · apply Measurable.aestronglyMeasurable |
There was a problem hiding this comment.
Flagging this for the future: it would be nice to avoid the Measurable.aestronglyMeasurable lemma; fun_prop should infer this instead.
There was a problem hiding this comment.
Just to be clear, in order for that to work properly, we need to mark AEStronglyMeasurable (the definition) with the fun_prop attribute. (EDIT: I see you did in this PR)
- seven out of nine goals use positivity - the second last one works by measurability: this is only because aesop calls simp_all; simp_all proves this and doesn't use any measurability lemma - the last one is truly measurability
grunweg
removed
the
merge-conflict
grunweg
commented
Jun 24, 2024
|
@RemyDegenne This is the follow-up PR I promised; I guess you're interested. It does even yield some slight speed-ups. |
|
!bench |
|
Here are the benchmark results for commit 72b694e. Benchmark Metric Change
==========================================================================
+ ~Mathlib.Analysis.SpecialFunctions.JapaneseBracket instructions -64.3% |
|
Comparing the two benchmarking runs, the second one is a minor improvement (save for |
leanprover-community-mathlib4-bot
added
the
merge-conflict
grunweg
added
tech debt
leanprover-community-mathlib4-bot
added
the
merge-conflict
grunweg
removed
the
merge-conflict
j-loreaux
reviewed
Jul 11, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
Co-authored-by: grunweg <[email protected]>
|
bors d+ |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks for the review. Since CI passes, let me |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…rability` calls (#13871) Replace manual `measurability` calls with `fun_prop`; replace `measurability` calls by `fun_prop` when possible. As a by-product, this tags a few more lemmas `fun_prop` and resolves all porting notes involving `measurability`. Follow- up to #13770. Co-authored-by: Johan Commelin <[email protected]>
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…rability` calls (#13871) Replace manual `measurability` calls with `fun_prop`; replace `measurability` calls by `fun_prop` when possible. As a by-product, this tags a few more lemmas `fun_prop` and resolves all porting notes involving `measurability`. Follow- up to #13770. Co-authored-by: Johan Commelin <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
measurability callsmeasurability calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace manual
measurabilitycalls withfun_prop; replacemeasurabilitycalls byfun_propwhen possible.As a by-product, this tags a few more lemmas
fun_propand resolves all porting notes involvingmeasurability.Follow- up to #13770.