Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Condensed): make the definition of underlying light condensed set match that of the underlying condensed set #13901

Closed
wants to merge 1 commit into from

Conversation

dagurtomas
Copy link
Collaborator

... this code had been copied from an old version of the condensed definition by accident.


Open in Gitpod

…et match that of the underlying condensed set
@dagurtomas dagurtomas added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI t-condensed Condensed mathematics labels Jun 17, 2024
Copy link

PR summary 7d4f09684b

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@joneugster
Copy link
Collaborator

Looks good.

Indeed the two objects here are isomorphic, so this doesn't change the definition:

open CategoryTheory Limits

noncomputable
def tmp : ⊤_ LightProfinite ≅ LightProfinite.of PUnit :=
  CategoryTheory.Limits.terminalIsoIsTerminal LightProfinite.isTerminalPUnit

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by joneugster.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 27, 2024
…et match that of the underlying condensed set (#13901)

... this code had been copied from an old version of the condensed definition by accident.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Condensed): make the definition of underlying light condensed set match that of the underlying condensed set [Merged by Bors] - chore(Condensed): make the definition of underlying light condensed set match that of the underlying condensed set Jun 27, 2024
@mathlib-bors mathlib-bors bot closed this Jun 27, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/LightDiscreteRedefine branch June 27, 2024 17:33
dagurtomas added a commit that referenced this pull request Jul 2, 2024
…et match that of the underlying condensed set (#13901)

... this code had been copied from an old version of the condensed definition by accident.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-condensed Condensed mathematics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants