Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: categorise porting notes related to ext #13928

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - chore: categorise porting notes related to ext #13928

wants to merge 7 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jun 18, 2024 •
edited
Loading

Fix some porting notes about ext and classifies the remaining ones about ext

The remaining porting notes mentioning ext are categorised by the issues

Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

PR summary a694133598

Import changes

No significant changes to the import graph

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

joneugster
joneugster commented Jun 18, 2024
View reviewed changes
@joneugster joneugster added awaiting-review porting-notes Mathlib3 to Mathlib4 porting notes. labels Jun 18, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jun 20, 2024
@jcommelin jcommelin requested a review from pitmonticone June 26, 2024 12:32
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 26, 2024
pitmonticone
pitmonticone reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@pitmonticone pitmonticone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally LGTM. I have resolved the merge conflict and suggested a few minor changes that can be directly committed from browser pretty quickly.

@jcommelin

@pitmonticone pitmonticone added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 26, 2024
@jcommelin
Copy link
Member

@joneugster @pitmonticone if you are both happy, I think this will be ready for merging.

@pitmonticone
Copy link
Collaborator

Yes, happy with that.

@joneugster
Copy link
Collaborator Author

me too!

@joneugster joneugster added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 26, 2024
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 27, 2024
@joneugster @pitmonticone
chore: categorise porting notes related to ext (#13928)
9ab745f 
Fix some porting notes about `ext` and classifies the remaining ones about `ext`



Co-authored-by: Pietro Monticone <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: categorise porting notes related to ext [Merged by Bors] - chore: categorise porting notes related to ext Jun 27, 2024
@mathlib-bors mathlib-bors bot closed this Jun 27, 2024
@mathlib-bors mathlib-bors bot deleted the eugster/porting-notes-007 branch June 27, 2024 12:07
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@joneugster @pitmonticone @dagurtomas
chore: categorise porting notes related to ext (#13928)
6ccbf84 
Fix some porting notes about `ext` and classifies the remaining ones about `ext`



Co-authored-by: Pietro Monticone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@pitmonticone pitmonticone pitmonticone left review comments

Assignees
No one assigned
Labels
porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joneugster @jcommelin @pitmonticone @leanprover-community-mathlib4-bot