[Merged by Bors] - feat: add Repr instance for quaternions #13940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new-contributor
PR summary 1495383ce1Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
eric-wieser
reviewed
Jun 18, 2024
Mathlib/Algebra/Quaternion.lean
Outdated
| For the typical case of quaternions over ℝ, each component will show as a Cauchy sequence due to | ||
| the way Real numbers are represented. | ||
| -/ | ||
| unsafe instance [Repr R] {a b : R} : Repr ℍ[R, a, b] where |
There was a problem hiding this comment.
Suggested change
| unsafe instance [Repr R] {a b : R} : Repr ℍ[R, a, b] where | |
| instance [Repr R] {a b : R} : Repr ℍ[R, a, b] where |
|
Could you add a test? There should be one somewhere that already tests complex numbers that you can copy. If you can't find it, I can have a look in a day or two. |
|
@eric-wieser it seems like this might have fallen through the cracks. Are you happy? bors d=eric-wieser |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
Adds a Repr instance for QuaternionAlgebra. A quaternion <w, x, y, z> is shown as "{ re := w, imI := x, imJ := y, imK := z }". The components are displayed as Cauchy sequences for quaternions over the Reals.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
Adds a Repr instance for QuaternionAlgebra. A quaternion <w, x, y, z> is shown as "{ re := w, imI := x, imJ := y, imK := z }". The components are displayed as Cauchy sequences for quaternions over the Reals.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Adds a Repr instance for QuaternionAlgebra. A quaternion <w, x, y, z> is shown as "{ re := w, imI := x, imJ := y, imK := z }". The components are displayed as Cauchy sequences for quaternions over the Reals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Repr instance for QuaternionAlgebra. A quaternion <w, x, y, z> is shown as "{ re := w, imI := x, imJ := y, imK := z }". The components are displayed as Cauchy sequences for quaternions over the Reals.