Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: the restriction functor on homological complexes #13991

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: the restriction functor on homological complexes #13991

wants to merge 9 commits into from

Conversation

joelriou
Copy link
Collaborator

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jun 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

PR summary 6dd9192e53

Import changes

No significant changes to the import graph

Declarations diff

+ instance [HasZeroMorphisms C] : (e.restrictionFunctor C).PreservesZeroMorphisms
+ instance [Preadditive C] : (e.restrictionFunctor C).Additive
+ restriction
+ restrictionFunctor
+ restrictionMap
+ restrictionMap_comp
+ restrictionMap_f'
+ restrictionMap_id
+ restrictionXIso
+ restriction_d_eq

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@callesonne callesonne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 22, 2024
joelriou and others added 3 commits June 22, 2024 18:31
@joelriou
Merge remote-tracking branch 'origin' into embedding-restriction
04d762a
@joelriou @github-actions
Update Mathlib/Algebra/Homology/Embedding/Restriction.lean
2df3511 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joelriou
Merge branch 'embedding-restriction' of github.com:leanprover-communi…
6dd9192 
…ty/mathlib4 into embedding-restriction
@joelriou joelriou added awaiting-review awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 22, 2024
callesonne
callesonne approved these changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@erdOne
Copy link
Member

erdOne commented Jun 23, 2024

Thanks! (and thanks Calle!)
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@kbuzzard
Copy link
Member

Thanks to everyone involved!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 23, 2024
@joelriou
feat: the restriction functor on homological complexes (#13991)
6cb118d 
Co-authored-by: Joël Riou <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the restriction functor on homological complexes [Merged by Bors] - feat: the restriction functor on homological complexes Jun 23, 2024
@mathlib-bors mathlib-bors bot closed this Jun 23, 2024
@mathlib-bors mathlib-bors bot deleted the embedding-restriction branch June 23, 2024 21:44
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
@joelriou @kbuzzard
feat: the restriction functor on homological complexes (#13991)
75b65d1 
Co-authored-by: Joël Riou <[email protected]>
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@joelriou @dagurtomas
feat: the restriction functor on homological complexes (#13991)
6989cd8 
Co-authored-by: Joël Riou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@callesonne callesonne callesonne approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelriou @erdOne @kbuzzard @callesonne