Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry): Define affine morphisms #13996

Closed
wants to merge 20 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jun 20, 2024


Open in Gitpod

Copy link

github-actions bot commented Jun 20, 2024

PR summary 076dae1e7c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Morphisms.Affine 1608

Declarations diff

+ IsAffineHom
+ affinePreimage
+ bijective
+ iSup_basicOpen_eq_top_iff
+ iSup_basicOpen_eq_top_iff'
+ iSup_basicOpen_of_span_eq_top
+ instance (priority := 100) isAffineHom_of_isAffine [IsAffine X] [IsAffine Y] : IsAffineHom f
+ instance (priority := 900) [IsAffineHom f] : QuasiCompact f
+ instance (priority := 900) [IsIso f] : IsAffineHom f
+ instance : HasAffineProperty @IsAffineHom fun X _ _ _ ↦ IsAffine X
+ instance : MorphismProperty.IsMultiplicative @IsAffineHom
+ instance [IsAffineHom f] [IsAffineHom g] : IsAffineHom (f ≫ g) := by
+ instance {X : Scheme} (r : Γ(X, ⊤)) :
+ isAffineHom_stableUnderBaseChange
+ isAffineOpen.preimage
+ isAffineOpen_of_isAffineOpen_basicOpen
+ isAffineOpen_of_isAffineOpen_basicOpen_aux
+ isAffine_of_isAffineHom
+ isAffine_of_isAffineOpen_basicOpen
+ isIso_ΓSpec_adjunction_unit_app_basicOpen

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@erdOne erdOne added the WIP Work in progress label Jun 20, 2024
erdOne and others added 4 commits June 21, 2024 07:12
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@erdOne erdOne added t-algebraic-geometry Algebraic geometry awaiting-review and removed WIP Work in progress labels Jun 21, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 22, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 23, 2024
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great but it would be even better if we had a more detailed module docstring.

@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 23, 2024
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes label Jun 24, 2024
@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 25, 2024
@erdOne erdOne added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 26, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 12, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 18, 2024
@joelriou
Copy link
Collaborator

Thanks!

bors merg

@kim-em
Copy link
Contributor

kim-em commented Jul 25, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 25, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): Define affine morphisms [Merged by Bors] - feat(AlgebraicGeometry): Define affine morphisms Jul 26, 2024
@mathlib-bors mathlib-bors bot closed this Jul 26, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/affineHom branch July 26, 2024 00:02
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants