Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/Inseparable): Define specializing maps between topological spaces #14001

Closed
wants to merge 10 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jun 20, 2024

Copy link

github-actions bot commented Jun 20, 2024

PR summary b023c877be

Import changes

No significant changes to the import graph


Declarations diff

+ Fibration.isLowerSet_image
+ Fibration.isUpperSet_image
+ GeneralizingMap
+ GeneralizingMap.stableUnderGeneralization_image
+ GeneralizingMap.stableUnderGeneralization_range
+ GeneralizingMap_iff_stableUnderGeneralization_image
+ Inducing.generalizingMap
+ Inducing.specializingMap
+ IsClosed.stableUnderSpecialization
+ IsClosedMap.specializingMap
+ IsOpen.stableUnderGeneralization
+ OpenEmbedding.generalizingMap
+ SpecializingMap
+ SpecializingMap.stableUnderSpecialization_image
+ SpecializingMap.stableUnderSpecialization_range
+ StableUnderGeneralization
+ StableUnderGeneralization.image
+ StableUnderGeneralization.preimage
+ StableUnderSpecialization
+ StableUnderSpecialization.image
+ StableUnderSpecialization.preimage
+ Union_closure_singleton_eq_iff
+ _root_.IsLowerSet.image_fibration
+ _root_.IsUpperSet.image_fibration
+ closure_singleton_eq_Iic
+ fibration_iff_image_Ici
+ fibration_iff_image_Iic
+ fibration_iff_isLowerSet_image
+ fibration_iff_isLowerSet_image_Iic
+ fibration_iff_isUpperSet_image
+ fibration_iff_isUpperSet_image_Ici
+ lowerClosure_eq
+ specializingMap_iff_closure_singleton
+ specializingMap_iff_closure_singleton_subset
+ specializingMap_iff_isClosed_image_closure_singleton
+ specializingMap_iff_stableUnderSpecialization_image
+ specializingMap_iff_stableUnderSpecialization_image_singleton
+ stableUnderGeneralization_compl_iff
+ stableUnderGeneralization_empty
+ stableUnderGeneralization_iInter
+ stableUnderGeneralization_iUnion
+ stableUnderGeneralization_iff_exists_sInter_eq
+ stableUnderGeneralization_sInter
+ stableUnderGeneralization_sUnion
+ stableUnderGeneralization_univ
+ stableUnderSpecialization_compl_iff
+ stableUnderSpecialization_empty
+ stableUnderSpecialization_iInter
+ stableUnderSpecialization_iUnion
+ stableUnderSpecialization_iff_Union_eq
+ stableUnderSpecialization_iff_exists_sUnion_eq
+ stableUnderSpecialization_sInter
+ stableUnderSpecialization_sUnion
+ stableUnderSpecialization_univ
+ upperClosure_eq
+ ⟨SpecializingMap.closure_singleton_subset,
+ ⟨StableUnderSpecialization.Union_eq,
++ ⟨_,

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@erdOne erdOne added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jun 20, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@alreadydone
Copy link
Contributor

Since I approved the mathlib3 PR, I'd approve this too once indentation is fixed.

@erdOne erdOne requested a review from alreadydone June 28, 2024 01:05
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close, just four are remaining!

Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@kim-em
Copy link
Contributor

kim-em commented Jul 2, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 2, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Build failed:

@riccardobrasca
Copy link
Member

Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Inseparable): Define specializing maps between topological spaces [Merged by Bors] - feat(Topology/Inseparable): Define specializing maps between topological spaces Jul 3, 2024
@mathlib-bors mathlib-bors bot closed this Jul 3, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/specializing branch July 3, 2024 10:14
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants