Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(lint-style): rewrite the linter for plain string adaptation notes in Lean #14058

Closed
wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jun 23, 2024

In true fashion, the linter (correctly) flags itself; we add these to the nolints file.


Open in Gitpod

grunweg added 2 commits June 23, 2024 20:45
Also remove the last ERR_OPT reference: that lint is not a syntax linter,
so this can safely be removed.
Copy link

github-actions bot commented Jun 23, 2024

PR summary f1c43d05db

Import changes

No significant changes to the import graph


Declarations diff

+ adaptationNoteLinter
- adaptation_note_check(lines,

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Contributor

kim-em commented Jun 24, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
…es in Lean (#14058)

In true fashion, the linter (correctly) flags itself; we add these to the nolints file.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(lint-style): rewrite the linter for plain string adaptation notes in Lean [Merged by Bors] - feat(lint-style): rewrite the linter for plain string adaptation notes in Lean Jun 24, 2024
@mathlib-bors mathlib-bors bot closed this Jun 24, 2024
@mathlib-bors mathlib-bors bot deleted the MR-rewrite-adaptation-note branch June 24, 2024 01:06
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
…es in Lean (#14058)

In true fashion, the linter (correctly) flags itself; we add these to the nolints file.
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…es in Lean (#14058)

In true fashion, the linter (correctly) flags itself; we add these to the nolints file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-linter Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants