-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: if the body constrains universes, make it explicit in the signature. #14069
Conversation
PR summary b30ac189dfImport changesNo significant changes to the import graph
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other changes look good.
Just to make sure, by RHS you mean example : LHS := RHS
, not example : LHS = RHS := ...
? I would rather call that the "body" of the declaration.
Co-authored-by: sgouezel <[email protected]>
Co-authored-by: sgouezel <[email protected]>
…mathlib4 into universes_from_rhs
bors r+ |
…ture. (#14069) In many places in Mathlib universes in the type signature are invisibly constrained by the RHS of the `def`. This PR makes all these explicit in the type signature. Likely we will change the Lean behaviour to disallow this in leanprover/lean4#4482 (i.e. this is the backport to `master` of the fixes required for that).
Pull request successfully merged into master. Build succeeded: |
…ture. (#14069) In many places in Mathlib universes in the type signature are invisibly constrained by the RHS of the `def`. This PR makes all these explicit in the type signature. Likely we will change the Lean behaviour to disallow this in leanprover/lean4#4482 (i.e. this is the backport to `master` of the fixes required for that).
…ture. (#14069) In many places in Mathlib universes in the type signature are invisibly constrained by the RHS of the `def`. This PR makes all these explicit in the type signature. Likely we will change the Lean behaviour to disallow this in leanprover/lean4#4482 (i.e. this is the backport to `master` of the fixes required for that).
In many places in Mathlib universes in the type signature are invisibly constrained by the RHS of the
def
.This PR makes all these explicit in the type signature.
Likely we will change the Lean behaviour to disallow this in leanprover/lean4#4482 (i.e. this is the backport to
master
of the fixes required for that).