Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: enforce the predicate on the ContinuousFunctionalCalculus is nontrivial #14100

Closed
wants to merge 6 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Jun 24, 2024

add a condition to the unital and non-unital continuous functional calculus class which ensures that the predicate is nontrivial by requiring p 0 to hold. This guarantees in unital algebras that p (algebraMap R A r) holds, which is about all one can expect given that sometimes p := IsStarNormal.


see #14065 for motivation

Open in Gitpod

@j-loreaux j-loreaux requested review from ADedecker and dupuisf June 24, 2024 18:46
@j-loreaux j-loreaux added awaiting-review awaiting-CI t-analysis Analysis (normed *, calculus) labels Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

PR summary a3c62aa812

Import changes

No significant changes to the import graph


Declarations diff

+ cfc_predicate_algebraMap
+ cfc_predicate_one
+ cfc_predicate_zero
+ cfcₙ_predicate_zero
++-- cfc

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator Author

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ADedecker I know you're busy with other things, but I would appreciate it if you could take a few minutes to review this. Frederic and I talked about it and think it makes sense, but I wanted to make sure you agree.

@dupuisf
Copy link
Contributor

dupuisf commented Jul 2, 2024

@ADedecker I understand you're a bit busy at the moment, so I'll just go ahead and merge this.

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 2, 2024
… is nontrivial (#14100)

add a condition to the unital and non-unital continuous functional calculus class which ensures that the predicate is nontrivial by requiring `p 0` to hold. This guarantees in unital algebras that `p (algebraMap R A r)` holds, which is about all one can expect given that sometimes `p := IsStarNormal`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Build failed:

@dupuisf
Copy link
Contributor

dupuisf commented Jul 2, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 2, 2024
… is nontrivial (#14100)

add a condition to the unital and non-unital continuous functional calculus class which ensures that the predicate is nontrivial by requiring `p 0` to hold. This guarantees in unital algebras that `p (algebraMap R A r)` holds, which is about all one can expect given that sometimes `p := IsStarNormal`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: enforce the predicate on the ContinuousFunctionalCalculus is nontrivial [Merged by Bors] - refactor: enforce the predicate on the ContinuousFunctionalCalculus is nontrivial Jul 2, 2024
@mathlib-bors mathlib-bors bot closed this Jul 2, 2024
@mathlib-bors mathlib-bors bot deleted the j-loreaux/cfc-predicate-nontrivial branch July 2, 2024 19:19
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants