Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Logic): Add iff_assoc, iff_left_comm and iff_right_comm theorems #14101

Closed
wants to merge 1 commit into from

Conversation

IvanRenison
Copy link
Collaborator

This was in #13200, but I'm moving it to a separate pull request to keep that pull request small


Open in Gitpod

@IvanRenison IvanRenison added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, etc) labels Jun 24, 2024
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 24, 2024
Copy link

PR summary dc4f8461d1

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Logic.Lemmas 93 97 +4 (+4.30%)

Declarations diff

+ iff_assoc
+ iff_left_comm
+ iff_right_comm

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@j-loreaux
Copy link
Collaborator

I'm surprised these don't exist, but loogle says they don't. Because I'm not sure about the change in the import hierarchy:

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@fpvandoorn
Copy link
Member

Change in imports seems innocent to me.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
…eorems (#14101)

This was in #13200, but I'm moving it to a separate pull request to keep that pull request small
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Logic): Add iff_assoc, iff_left_comm and iff_right_comm theorems [Merged by Bors] - feat(Logic): Add iff_assoc, iff_left_comm and iff_right_comm theorems Jun 24, 2024
@mathlib-bors mathlib-bors bot closed this Jun 24, 2024
@mathlib-bors mathlib-bors bot deleted the IvanRenison/iff_lemmas branch June 24, 2024 23:52
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
…eorems (#14101)

This was in #13200, but I'm moving it to a separate pull request to keep that pull request small
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…eorems (#14101)

This was in #13200, but I'm moving it to a separate pull request to keep that pull request small
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants