Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(README): fix advice about updating dependencies #14109

Closed
wants to merge 1 commit into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jun 25, 2024

No description provided.

Copy link

PR summary 6c66ed3eaa

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em kim-em added documentation Improvements or additions to documentation awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 25, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward. (I cannot judge the Kdoc=on thing, but trust you that this part is correct.) In any case, this deserves another pair of eyes:
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@Vierkantor
Copy link
Contributor

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 25, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(README): fix advice about updating dependencies [Merged by Bors] - chore(README): fix advice about updating dependencies Jun 25, 2024
@mathlib-bors mathlib-bors bot closed this Jun 25, 2024
@mathlib-bors mathlib-bors bot deleted the README_dependencies branch June 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants