Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction #14115

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction #14115

wants to merge 4 commits into from

Conversation

LorenzoLuccioli
Copy link
Collaborator

@LorenzoLuccioli LorenzoLuccioli commented Jun 25, 2024 •
edited
Loading

  • Add StieltjesFunction.const and StieltjesFunction.add
  • Add lemmas const_apply and add_apply
  • Add instances AddCommMonoid StieltjesFunction and Module ℝ≥0 StieltjesFunction
  • Add lemmas measure_const, measure_add and measure_smul
  • Cleanup

Open in Gitpod

@LorenzoLuccioli LorenzoLuccioli added awaiting-review t-measure-probability Measure theory / Probability theory labels Jun 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

PR summary 9c45eadab8

Import changes

No significant changes to the import graph

Declarations diff

+ add
+ add_apply
+ const
+ const_apply
+ instance : AddCommMonoid StieltjesFunction
+ instance : AddZeroClass StieltjesFunction
+ instance : Module ℝ≥0 StieltjesFunction
+ measure_add
+ measure_const
+ measure_smul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@LorenzoLuccioli LorenzoLuccioli marked this pull request as ready for review June 25, 2024 11:31
sgouezel
sgouezel reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 25, 2024

✌️ LorenzoLuccioli can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@LorenzoLuccioli LorenzoLuccioli requested a review from sgouezel June 25, 2024 15:18
@LorenzoLuccioli
Copy link
Collaborator Author

Sorry, I slightly changed the instance, separating the AddZeroClass instance to shorten the proof. I think it needs another quick review before merging.

@RemyDegenne
Copy link
Contributor

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by RemyDegenne.

@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 26, 2024
@LorenzoLuccioli
feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction (#…
bc984f0 
…14115)

- Add `StieltjesFunction.const` and `StieltjesFunction.add`
- Add lemmas `const_apply` and `add_apply`
- Add instances `AddCommMonoid StieltjesFunction` and `Module ℝ≥0 StieltjesFunction`
- Add lemmas `measure_const`, `measure_add` and `measure_smul`
- Cleanup
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction [Merged by Bors] - feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction Jun 26, 2024
@mathlib-bors mathlib-bors bot closed this Jun 26, 2024
@mathlib-bors mathlib-bors bot deleted the LL/Stieltjes branch June 26, 2024 09:52
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
@LorenzoLuccioli @kbuzzard
feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction (#…
7cf9f98 
…14115)

- Add `StieltjesFunction.const` and `StieltjesFunction.add`
- Add lemmas `const_apply` and `add_apply`
- Add instances `AddCommMonoid StieltjesFunction` and `Module ℝ≥0 StieltjesFunction`
- Add lemmas `measure_const`, `measure_add` and `measure_smul`
- Cleanup
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@LorenzoLuccioli @dagurtomas
feat(Measure/Stieltjes): Add instance Module ℝ≥0 StieltjesFunction (#…
43f7ce9 
…14115)

- Add `StieltjesFunction.const` and `StieltjesFunction.add`
- Add lemmas `const_apply` and `add_apply`
- Add instances `AddCommMonoid StieltjesFunction` and `Module ℝ≥0 StieltjesFunction`
- Add lemmas `measure_const`, `measure_add` and `measure_smul`
- Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LorenzoLuccioli @RemyDegenne @sgouezel @leanprover-community-mathlib4-bot