Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Logic/Basic): drop 3 long-deprecated theorems #14157

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Logic/Basic): drop 3 long-deprecated theorems #14157

wants to merge 1 commit into from
+3 −13

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 26, 2024

Open in Gitpod

@urkud urkud added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip t-logic Logic (model theory, etc) labels Jun 26, 2024
@github-actions GitHub Actions
Copy link

PR summary 98bd5abb39

Import changes

No significant changes to the import graph

Declarations diff

- or_of_or_of_imp_left
- or_of_or_of_imp_of_imp
- or_of_or_of_imp_right

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@grunweg
Copy link
Collaborator

grunweg commented Jun 26, 2024

Thanks for doing this! Since the build already was successful, let me
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 26, 2024
@urkud
chore(Logic/Basic): drop 3 long-deprecated theorems (#14157)
7cf04c3
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Logic/Basic): drop 3 long-deprecated theorems [Merged by Bors] - chore(Logic/Basic): drop 3 long-deprecated theorems Jun 26, 2024
@mathlib-bors mathlib-bors bot closed this Jun 26, 2024
@mathlib-bors mathlib-bors bot deleted the YK-depr branch June 26, 2024 17:20
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
@urkud @kbuzzard
chore(Logic/Basic): drop 3 long-deprecated theorems (#14157)
7c356e7
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@urkud @dagurtomas
chore(Logic/Basic): drop 3 long-deprecated theorems (#14157)
4ef6095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urkud @grunweg @fpvandoorn