Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(NumberField/CanonicalEmbedding): add canonicalEmbedding.integralBasis_repr_apply #14158

Closed
wants to merge 2 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jun 26, 2024

Prove that the representation on the latticeBasis of the canonical space of the image of an algebraic number is equal to its representation of the integral basis.


Open in Gitpod

@xroblot xroblot added awaiting-review awaiting-CI t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Jun 26, 2024
Copy link

PR summary 358a3dea92

Import changes

No significant changes to the import graph


Declarations diff

+ integralBasis_repr_apply
+ mem_rat_span_latticeBasis

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 27, 2024
…lBasis_repr_apply` (#14158)

Prove that the representation on the `latticeBasis` of the canonical space of the image of an algebraic number is equal to its representation of the integral basis.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberField/CanonicalEmbedding): add canonicalEmbedding.integralBasis_repr_apply [Merged by Bors] - feat(NumberField/CanonicalEmbedding): add canonicalEmbedding.integralBasis_repr_apply Jun 27, 2024
@mathlib-bors mathlib-bors bot closed this Jun 27, 2024
@mathlib-bors mathlib-bors bot deleted the xfr_canonicalEmbedding_repr_apply branch June 27, 2024 12:40
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…lBasis_repr_apply` (#14158)

Prove that the representation on the `latticeBasis` of the canonical space of the image of an algebraic number is equal to its representation of the integral basis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants