-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(CategoryTheory): Split equalizers #14170
Conversation
PR summary acae65ca35Import changesNo significant changes to the import graph
|
HasSplitEqualizer (G.map f) (G.map g) | ||
|
||
/-- Get the equalizer object from the typeclass `IsCosplitPair`. -/ | ||
noncomputable def HasSplitEqualizer.equalizerOfCosplit [HasSplitEqualizer f g] : C := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This def should be called HasSplitEqualizer.equalizer
or something like that, as it has nothing to do with CosplitPair
. I guess it's adapted from the other file, in which case that should be changed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I changed this name to HasSplitEqualizer.equalizerOfSplit
, and didn't touch it in the other file. The Split
in the name in the other file doesn't refer to Functor.IsSplitPair
, hence we shouldn't use `Cosplit here.
bors d+ |
✌️ mckoen can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Kim Morrison <[email protected]>
bors merge |
Defines what it means for a triple of morphisms `f g : X ⟶ Y`, `ι : W ⟶ X` to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute. This dualises everything in [Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Limits/Shapes/SplitCoequalizer.html). This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024. Co-authored-by: dagurtomas <[email protected]> Co-authored-by: Jack <[email protected]>
This PR was included in a batch that was canceled, it will be automatically retried |
Defines what it means for a triple of morphisms `f g : X ⟶ Y`, `ι : W ⟶ X` to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute. This dualises everything in [Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Limits/Shapes/SplitCoequalizer.html). This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024. Co-authored-by: dagurtomas <[email protected]> Co-authored-by: Jack <[email protected]>
Build failed (retrying...): |
Canceled. |
What is the situation with this PR? |
I'm not sure, I thought it was okay to merge but it was cancelled for some reason. I'm not very familiar with Bors so maybe I did something wrong |
Something failed, can you merge master and see what's wrong? |
Thanks! bors merge |
Defines what it means for a triple of morphisms `f g : X ⟶ Y`, `ι : W ⟶ X` to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute. This dualises everything in [Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Limits/Shapes/SplitCoequalizer.html). This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024. Co-authored-by: dagurtomas <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Joël Riou <[email protected]>
Pull request successfully merged into master. Build succeeded: |
Defines what it means for a triple of morphisms
f g : X ⟶ Y
,ι : W ⟶ X
to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute.This dualises everything in Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer.
This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.