Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory): Split equalizers #14170

Closed
wants to merge 8 commits into from

Conversation

mckoen
Copy link
Collaborator

@mckoen mckoen commented Jun 26, 2024

Defines what it means for a triple of morphisms f g : X ⟶ Y, ι : W ⟶ X to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute.

This dualises everything in Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer.

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.


Open in Gitpod

@mckoen mckoen added the t-category-theory Category theory label Jun 26, 2024
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 26, 2024
@mckoen mckoen changed the title feat(CategoryTheory): Split Equalizers feat(CategoryTheory): Split equalizers Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

PR summary acae65ca35

Import changes

No significant changes to the import graph


Declarations diff

+ HasSplitEqualizer
+ HasSplitEqualizer.equalizerOfSplit
+ HasSplitEqualizer.equalizerι
+ HasSplitEqualizer.isSplitEqualizer
+ IsSplitEqualizer
+ IsSplitEqualizer.asFork
+ IsSplitEqualizer.asFork_ι
+ IsSplitEqualizer.isEqualizer
+ IsSplitEqualizer.map
+ instance (priority := 1) hasEqualizer_of_hasSplitEqualizer [HasSplitEqualizer f g] :
+ instance {X : C} : Inhabited (IsSplitEqualizer (𝟙 X) (𝟙 X) (𝟙 X))
+ map_is_cosplit_pair

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

HasSplitEqualizer (G.map f) (G.map g)

/-- Get the equalizer object from the typeclass `IsCosplitPair`. -/
noncomputable def HasSplitEqualizer.equalizerOfCosplit [HasSplitEqualizer f g] : C :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This def should be called HasSplitEqualizer.equalizer or something like that, as it has nothing to do with CosplitPair. I guess it's adapted from the other file, in which case that should be changed too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I changed this name to HasSplitEqualizer.equalizerOfSplit, and didn't touch it in the other file. The Split in the name in the other file doesn't refer to Functor.IsSplitPair, hence we shouldn't use `Cosplit here.

@mckoen mckoen added the workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry label Jun 28, 2024
@kim-em
Copy link
Contributor

kim-em commented Jun 29, 2024

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 29, 2024

✌️ mckoen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mckoen
Copy link
Collaborator Author

mckoen commented Jul 1, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Defines what it means for a triple of morphisms `f g : X ⟶ Y`, `ι : W ⟶ X` to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute.

This dualises everything in [Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Limits/Shapes/SplitCoequalizer.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <[email protected]>
Co-authored-by: Jack <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Defines what it means for a triple of morphisms `f g : X ⟶ Y`, `ι : W ⟶ X` to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute.

This dualises everything in [Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Limits/Shapes/SplitCoequalizer.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <[email protected]>
Co-authored-by: Jack <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Canceled.

@riccardobrasca
Copy link
Member

What is the situation with this PR?

@riccardobrasca riccardobrasca added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 2, 2024
@mckoen
Copy link
Collaborator Author

mckoen commented Jul 2, 2024

What is the situation with this PR?

I'm not sure, I thought it was okay to merge but it was cancelled for some reason. I'm not very familiar with Bors so maybe I did something wrong

@riccardobrasca
Copy link
Member

Something failed, can you merge master and see what's wrong?

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 2, 2024
Defines what it means for a triple of morphisms `f g : X ⟶ Y`, `ι : W ⟶ X` to be a split equalizer. In addition, shows that every split equalizer is an equalizer and absolute.

This dualises everything in [Mathlib.CategoryTheory.Limits.Shapes.SplitCoequalizer](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Limits/Shapes/SplitCoequalizer.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Joël Riou <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): Split equalizers [Merged by Bors] - feat(CategoryTheory): Split equalizers Jul 2, 2024
@mathlib-bors mathlib-bors bot closed this Jul 2, 2024
@mathlib-bors mathlib-bors bot deleted the mckoen/AIM_comonadicity branch July 2, 2024 19:29
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry t-category-theory Category theory workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants