Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/Homology): remove unnecessary ReflectsEpimorphisms instance #14200

Closed
wants to merge 3 commits into from

Conversation

dagurtomas
Copy link
Collaborator


I just randomly noticed that this was stated as an instance when it in fact holds in more generality

Open in Gitpod

@dagurtomas dagurtomas added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI t-category-theory Category theory t-algebra Algebra (groups, rings, fields, etc) labels Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

PR summary b92f0cada8

Import changes

No significant changes to the import graph


Declarations diff

- instance [Faithful F] [CategoryWithHomology C] : F.ReflectsEpimorphisms
- instance [Faithful F] [CategoryWithHomology C] : F.ReflectsMonomorphisms

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@erdOne
Copy link
Member

erdOne commented Jun 27, 2024

Thanks
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

dagurtomas and others added 2 commits June 28, 2024 07:23
Co-authored-by: Joël Riou <[email protected]>
Co-authored-by: Joël Riou <[email protected]>
@joelriou
Copy link
Collaborator

Thankd!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 28, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Homology): remove unnecessary ReflectsEpimorphisms instance [Merged by Bors] - chore(Algebra/Homology): remove unnecessary ReflectsEpimorphisms instance Jun 28, 2024
@mathlib-bors mathlib-bors bot closed this Jun 28, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/RemoveReflectsEpiInstances branch June 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants