Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(AddConstMap): don't extend FunLike #14201

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 27, 2024

Instead, take it as an argument as other bundled homs do.
Also change the npow field in the Monoid instance so that coe_pow is a rfl lemma now.


Open in Gitpod

Instead, take it as an argument as other bundled homs do.
@urkud urkud added awaiting-review t-dynamics Dynamical Systems labels Jun 27, 2024
Copy link

PR summary ac4df7dec2

Import changes

No significant changes to the import graph


Declarations diff

+ instance : FunLike (G →+c[a, b] H) G H
+ instance : Mul (G →+c[a, a] G) := ⟨comp⟩
+ instance : One (G →+c[a, a] G) := ⟨.id⟩
+ instance : Pow (G →+c[a, a] G) ℕ
+ toFun_eq_coe

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@dupuisf
Copy link
Contributor

dupuisf commented Jun 27, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 27, 2024
Instead, take it as an argument as other bundled homs do.
Also change the `npow` field in the `Monoid` instance so that `coe_pow` is a `rfl` lemma now.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(AddConstMap): don't extend FunLike [Merged by Bors] - chore(AddConstMap): don't extend FunLike Jun 27, 2024
@mathlib-bors mathlib-bors bot closed this Jun 27, 2024
@mathlib-bors mathlib-bors bot deleted the YK-add-const-map branch June 27, 2024 19:44
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Instead, take it as an argument as other bundled homs do.
Also change the `npow` field in the `Monoid` instance so that `coe_pow` is a `rfl` lemma now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-dynamics Dynamical Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants