Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/PNat): drop bit* lemmas #14217

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 28, 2024

Add OfNat lemmas instead.


Open in Gitpod

Add `OfNat` lemmas instead.
@urkud urkud added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip awaiting-CI labels Jun 28, 2024
Copy link

PR summary e1c5f4b274

Import changes

No significant changes to the import graph


Declarations diff

+ ofNat_inj
+ ofNat_le_ofNat
+ ofNat_lt_ofNat
- bit0_le_bit0
- bit0_le_bit1
- bit1_le_bit0
- bit1_le_bit1

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes awaiting-review and removed awaiting-review awaiting-author A reviewer has asked the author a question or requested changes labels Jun 28, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 1, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Add `OfNat` lemmas instead.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Add `OfNat` lemmas instead.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Add `OfNat` lemmas instead.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Add `OfNat` lemmas instead.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/PNat): drop bit* lemmas [Merged by Bors] - chore(Data/PNat): drop bit* lemmas Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the YK_pnat-bit branch July 1, 2024 16:40
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Add `OfNat` lemmas instead.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants