Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: delay imports of Star (part 2) #14221

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - chore: delay imports of Star (part 2) #14221

wants to merge 10 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jun 28, 2024 •
edited by mathlib-bors bot
Loading

No description provided.

@kim-em kim-em added the WIP Work in progress label Jun 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

PR summary 9acb3c392b

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Real.Star 1040 528 -512 (-49.23%)
Mathlib.Data.Real.Basic 527 515 -12 (-2.28%)
Mathlib.Analysis.Normed.Group.Seminorm 724 721 -3 (-0.41%)
Mathlib.Data.ENNReal.Basic 727 724 -3 (-0.41%)
Mathlib.RingTheory.Valuation.RankOne 918 917 -1 (-0.11%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 28, 2024
@kim-em kim-em added awaiting-review awaiting-CI and removed WIP Work in progress merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jun 28, 2024
@kim-em kim-em marked this pull request as ready for review June 28, 2024 12:56
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 28, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 29, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 29, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 29, 2024
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 30, 2024
eric-wieser
eric-wieser approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 30, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em
Copy link
Contributor Author

kim-em commented Jun 30, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 30, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 30, 2024

Canceled.

@kim-em
Copy link
Contributor Author

kim-em commented Jun 30, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jun 30, 2024
@kim-em
chore: delay imports of Star (part 2) (#14221)
fe1669a
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: delay imports of Star (part 2) [Merged by Bors] - chore: delay imports of Star (part 2) Jun 30, 2024
@mathlib-bors mathlib-bors bot closed this Jun 30, 2024
@mathlib-bors mathlib-bors bot deleted the star_real branch June 30, 2024 10:18
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@kim-em @dagurtomas
chore: delay imports of Star (part 2) (#14221)
fb903c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kim-em @eric-wieser @Ruben-VandeVelde @leanprover-community-mathlib4-bot