-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Data/Real/EReal): add inverse and division of ENNReal
s
#14224
Conversation
PR summary cbbfb55dffImport changesNo significant changes to the import graph
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bad idea to define a non-homogeneous division on EReal → ENNReal → EReal. Instead, as I discussed with Damien, one should define an homogeneous division on EReal, first be defining an inverse function and then using (a, b) -> a * b⁻¹.
ENNReal
sENNReal
s
ENNReal
sENNReal
s
Yes, I believe that is the new API in BET/TopologicalEntropy. @D-Thomine can you confirm? |
Co-Authored-By: Lorenzo Luccioli <[email protected]>
Co-Authored-By: Lorenzo Luccioli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good. Minor tweaks are required about the naming of lemmas, though.
Co-Authored-By: Lorenzo Luccioli <[email protected]>
I should have addressed all review comments. Thank you very much @sgouezel for your review! |
bors r+ |
This PR adds API for inverse and division of extended reals. Co-authored-by: @D-Thomine
Pull request successfully merged into master. Build succeeded: |
ENNReal
sENNReal
s
This PR adds API for inverse and division of extended reals. Co-authored-by: @D-Thomine
This PR adds API for inverse and division of extended reals.
Co-authored-by: @D-Thomine