[Merged by Bors] - perf (Algebra.AddConstMap): scope simp lemmas #14233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
PR summary 6b06d5bc1aImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
|
Here are the benchmark results for commit 6b06d5b. Benchmark Metric Change
=================================
+ lint instructions -14.3%
+ lint wall-clock -16.4% |
|
Note this is over 1 minute savings on the very fast benchmark server |
|
Thanks a lot for figuring this out! bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
The keys for these `simp` lemmas will match quite a bit. To avoid this, we scope them to the `AddConstMapClass` namespace so that you only have them when you need them and not when you don't.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
The keys for these `simp` lemmas will match quite a bit. To avoid this, we scope them to the `AddConstMapClass` namespace so that you only have them when you need them and not when you don't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys for these
simplemmas will match quite a bit. To avoid this, we scope them to theAddConstMapClassnamespace so that you only have them when you need them and not when you don't.