Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: reduce imports on the path to LinearMap #14246

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - chore: reduce imports on the path to LinearMap #14246

wants to merge 6 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jun 28, 2024

Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

PR summary c2c36b58c4

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Ring.Action.Basic 369 320 -49 (-13.28%)
Mathlib.GroupTheory.GroupAction.Hom 395 382 -13 (-3.29%)
Mathlib.Algebra.Ring.BooleanRing 520 516 -4 (-0.77%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

grunweg
grunweg reviewed Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. (You have one typo to fix.)
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 29, 2024
@kim-em @riccardobrasca
chore: reduce imports on the path to LinearMap (#14246)
3321494 
Co-authored-by: Riccardo Brasca <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: reduce imports on the path to LinearMap [Merged by Bors] - chore: reduce imports on the path to LinearMap Jun 29, 2024
@mathlib-bors mathlib-bors bot closed this Jun 29, 2024
@mathlib-bors mathlib-bors bot deleted the ring_action_imports branch June 29, 2024 10:04
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@kim-em @riccardobrasca @dagurtomas
chore: reduce imports on the path to LinearMap (#14246)
b68b97a 
Co-authored-by: Riccardo Brasca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg left review comments

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kim-em @sgouezel @grunweg @riccardobrasca