Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(LocallyConvex): add isVonNBounded_union etc #14275

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(LocallyConvex): add isVonNBounded_union etc #14275

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 30, 2024

Open in Gitpod

@urkud urkud added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jun 30, 2024
@urkud urkud mentioned this pull request Jun 30, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2024 •
edited
Loading

PR summary 94144aad12

Import changes

No significant changes to the import graph

Declarations diff

+ IsVonNBounded.of_boundedSpace
+ isVonNBounded_biUnion
+ isVonNBounded_iUnion
+ isVonNBounded_insert
+ isVonNBounded_sUnion
+ isVonNBounded_union
+ ⟨_,

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

eric-wieser
eric-wieser approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Analysis/LocallyConvex/Bounded.lean
@@ -92,11 +92,19 @@ theorem IsVonNBounded.subset {s₁ s₂ : Set E} (h : s₁ ⊆ s₂) (hs₂ : Is
IsVonNBounded 𝕜 s₁ := fun _ hV => (hs₂ hV).mono_right h
#align bornology.is_vonN_bounded.subset Bornology.IsVonNBounded.subset

@[simp]
theorem isVonNBounded_union {s t : Set E} :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the iUnion version too (we already have absorbs_iUnion)? Don't forget to ensure the index is in Sort not Type!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 30, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser changed the title feat(LocallyContex): add isVonNBounded_union etc feat(LocallyConvex): add isVonNBounded_union etc Jun 30, 2024
@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jul 1, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
@urkud
feat(LocallyConvex): add isVonNBounded_union etc (#14275)
8a42f33
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LocallyConvex): add isVonNBounded_union etc [Merged by Bors] - feat(LocallyConvex): add isVonNBounded_union etc Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the YK-vonn-union branch July 1, 2024 02:00
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@urkud @dagurtomas
feat(LocallyConvex): add isVonNBounded_union etc (#14275)
9e63624
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urkud @leanprover-community-mathlib4-bot @eric-wieser