Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/Polynomial/Div): rename mul_div_mod_by_monic_cancel_left to mul_divByMonic_cancel_left #14280

Closed
wants to merge 3 commits into from

Conversation

js2357
Copy link
Collaborator

@js2357 js2357 commented Jun 30, 2024

Rename mul_div_mod_by_monic_cancel_left to fit naming conventions and make the theorem easier to find.


Open in Gitpod

@js2357 js2357 added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Jun 30, 2024
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 30, 2024
Copy link

github-actions bot commented Jun 30, 2024

PR summary c001bdbaf4

Import changes

No significant changes to the import graph


Declarations diff

+ mul_divByMonic_cancel_left

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@eric-wieser
Copy link
Member

Can you add a deprecated alias to the old lemma name? I think if you start typing deprecated a snippet is generated by vscode.

@js2357
Copy link
Collaborator Author

js2357 commented Jul 1, 2024

Can you add a deprecated alias to the old lemma name? I think if you start typing deprecated a snippet is generated by vscode.

Done, thanks.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
…ft` to `mul_divByMonic_cancel_left` (#14280)

Rename `mul_div_mod_by_monic_cancel_left` to fit naming conventions and make the theorem easier to find.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Polynomial/Div): rename mul_div_mod_by_monic_cancel_left to mul_divByMonic_cancel_left [Merged by Bors] - chore(Algebra/Polynomial/Div): rename mul_div_mod_by_monic_cancel_left to mul_divByMonic_cancel_left Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the js2357/DivByMonic branch July 1, 2024 11:37
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…ft` to `mul_divByMonic_cancel_left` (#14280)

Rename `mul_div_mod_by_monic_cancel_left` to fit naming conventions and make the theorem easier to find.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants