-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: add LinearMap.IsAlt.eq_of_add_add_eq_zero
#14281
Conversation
PR summary 7857ad4e6eImport changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you prove this for LinearMap.IsAlt
too?
Here's a proof that works for semirings and not just rings: theorem isAlt.eq_of_add_add_eq_zero [IsCancelAdd R] {B : LinearMap.BilinForm R M} {a b c : M} (hB : B.IsAlt) (hSum : a + b + c = 0) :
B a b = B b c := by
have : B a a + B a b + B a c = B a c + B b c + B c c := by
simp_rw [← map_add, ← map_add₂, hSum, map_zero, zero_apply]
rw [hB, hB, zero_add, add_zero, add_comm] at this
exact add_left_cancel this I'll leave adapting this to |
I naively put this above |
It might need to be Another trick would be to just remove that lemma from the |
Updated (almost no change from your suggestion, which also worked well for Actually, I don't quite understand why we don't need |
isAlt.eq_of_add_add_zero
isAlt.eq_of_add_add_eq_zero
isAlt.eq_of_add_add_eq_zero
LinearMap.IsAlt.eq_of_add_add_eq_zero
Co-authored-by: Eric Wieser <[email protected]>
bors merge Thanks, this now looks great! |
For an alternating form $B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$, we have $B(a, b) = B(b, c)$. This can be used to prove the same property of Wronskian: see #14243. Co-authored-by: Seewoo Lee <[email protected]>
Build failed (retrying...): |
For an alternating form $B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$, we have $B(a, b) = B(b, c)$. This can be used to prove the same property of Wronskian: see #14243. Co-authored-by: Seewoo Lee <[email protected]>
Pull request successfully merged into master. Build succeeded: |
LinearMap.IsAlt.eq_of_add_add_eq_zero
LinearMap.IsAlt.eq_of_add_add_eq_zero
For an alternating form $B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$, we have $B(a, b) = B(b, c)$. This can be used to prove the same property of Wronskian: see #14243. Co-authored-by: Seewoo Lee <[email protected]>
For an alternating form$B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$ , we have $B(a, b) = B(b, c)$ .
This can be used to prove the same property of Wronskian: see #14243.