Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: the forget functor from ModuleCat to AddCommGrp reflects all limits #14283

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: the forget functor from ModuleCat to AddCommGrp reflects all limits #14283

wants to merge 5 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Jun 30, 2024 •
edited
Loading

The forget functor from the category of modules to abelian groups reflects all limits (regardless of universes).

This may reduce universe assumptions in #14254.

This contribution was created as part of the AIM workshop "Formalizing algebraic geometry" in June 2024.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jun 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2024 •
edited
Loading

PR summary f5183f9e8e

Import changes

No significant changes to the import graph

Declarations diff

+ forget₂AddCommGroupReflectsLimitOfShape
+ forget₂AddCommGroupReflectsLimitOfSize

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@joelriou joelriou mentioned this pull request Jun 30, 2024
Closed
1 task
@joelriou joelriou added the workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry label Jun 30, 2024
erdOne
erdOne approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have t be the first in line 24.
Otherwise LGTM.

@joelriou
Copy link
Collaborator Author

Maybe we should have t be the first in line 24. Otherwise LGTM.

Good idea. I have just put the universe t first.

@erdOne
Copy link
Member

erdOne commented Jul 3, 2024

Thanks!
maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

jcommelin
jcommelin reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2024
@joelriou
feat: the forget functor from ModuleCat to AddCommGrp reflects all li…
4900904 
…mits (#14283)

The forget functor from the category of modules to abelian groups reflects all limits (regardless of universes).

This may reduce universe assumptions in #14254.

This contribution was created as part of the AIM workshop "Formalizing algebraic geometry" in June 2024.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the forget functor from ModuleCat to AddCommGrp reflects all limits [Merged by Bors] - feat: the forget functor from ModuleCat to AddCommGrp reflects all limits Jul 3, 2024
@mathlib-bors mathlib-bors bot closed this Jul 3, 2024
@mathlib-bors mathlib-bors bot deleted the forget-two-modulecat-ab-reflects-limits branch July 3, 2024 06:37
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@erdOne erdOne erdOne approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-category-theory Category theory workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelriou @erdOne @jcommelin @leanprover-community-mathlib4-bot