-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Nat): split Prime.lean #14286
Conversation
PR summary 7e4b3ac8c3Import changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
The following files now import the shorter Prime/Defs:
The follwing files still import the full Prime/Basic (dependency given):
|
!bench |
Here are the benchmark results for commit 7e4b3ac. Benchmark Metric Change
============================
- build linting 5.0% |
@mattrobball, this is just noise, right?? If so, I'm happy to proceed. |
Yes, we should crank up the limits for this on the benchmarking server |
bors merge |
Splitting `Prime.lean` into `Defs`, `Basic`. The split aims at separation of defs and needed lemmas from everything else. With this split 13/18 Mathlib modules no longer import the whole `Prime.lean`. `Prime/Defs.lean` is about half the size. Motivation is a circular dependency that would prevent me from adding a lemma to `Prime.lean`. https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/split.20Nat.2FPrime.2Elean
Pull request successfully merged into master. Build succeeded: |
Splitting `Prime.lean` into `Defs`, `Basic`. The split aims at separation of defs and needed lemmas from everything else. With this split 13/18 Mathlib modules no longer import the whole `Prime.lean`. `Prime/Defs.lean` is about half the size. Motivation is a circular dependency that would prevent me from adding a lemma to `Prime.lean`. https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/split.20Nat.2FPrime.2Elean
Splitting
Prime.lean
intoDefs
,Basic
. The split aims at separation of defs and needed lemmas from everything else. With this split 13/18 Mathlib modules no longer import the wholePrime.lean
.Prime/Defs.lean
is about half the size.Motivation is a circular dependency that would prevent me from adding a lemma to
Prime.lean
.https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/split.20Nat.2FPrime.2Elean